Page 1 of 1

[0.11.0] Minor bug in History page [RESOLVED 0.11.1]

Posted: Tue Jan 12, 2021 8:37 pm
by 13thsyndicate
So some of the background histories include you making friends with a person who is named several times in the entry... however,at least one version of the entry rerolls the name if not every time then several times throughout the entry. Not a huge priority but I don't think it's supposed to do that, might be a classic bug though, I don't remember very well.
Name glitch.jpg
Name glitch.jpg (520.67 KiB) Viewed 200 times
text bug 2.jpg
text bug 2.jpg (479.96 KiB) Viewed 200 times
This one does use the final name again to refer o the same person and it's reasonable that the three names listed could be three separate characters, but I've definitely encountered bios where this makes much less sense!

Re: [0.11.0] Minor bug in History page

Posted: Tue Jan 12, 2021 11:31 pm
by Interkarma
Source text is using macro %fn which just generates a random name. We could easily make this deterministic when processing backstories, provided only a single NPC name like this is used for each backstory. Otherwise, all NPCs would end up with the same name, which is also a problem.

Definitely one to review, I'll move to bug reports for later follow up. Cheers. :)

Re: [0.11.0] Minor bug in History page

Posted: Sat Jan 16, 2021 8:52 am
by Ferital
I submitted a PR to fix this bug.