Page 1 of 1

Modded music - does not revert to vanilla when mod is disabled ingame [RESOLVED]

Posted: Sun Jan 24, 2021 8:30 pm
by King of Worms
So, once the modded music DFMOD is in the "mods" folder, that modded music will be played ingame, no matter if the mod is actually ENABLED ingame or not.

Only way to revert music back to vanilla is by removing the DFMOD from the "mod" folder completely.

It appears as if the game reads the mod folder at runtime, and when there is a music DFMOD, it uses that music no matter the ingame settings?

Restarting the game does not solve the issue.

Expected behavior is:
Music reverts to vanilla when you DISABLE the mod in the mod settings

Re: Modded music - does not revert to vanilla when mod is disabled ingame

Posted: Sun Jan 24, 2021 9:14 pm
by TheLacus
Part of the issue should already be solved by a recent PR (assets are not seeked from disabled mods that haven't been yet unloaded), but songs are not cached so this should only affect the main title song.

Re: Modded music - does not revert to vanilla when mod is disabled ingame

Posted: Sun Jan 24, 2021 11:11 pm
by King of Worms
Ive noticed that PR, thanks for the info! Also, I did not know the intro song is a exception. I will test it properly after new release.

Re: Modded music - does not revert to vanilla when mod is disabled ingame

Posted: Fri May 07, 2021 4:10 am
by Interkarma
Sounds like this fix has already been merged. I'll close this one now.