[0.11.0] Missing music for Mages Guild

Post here if you need help getting started with Daggerfall Unity or just want to clarify a potential bug. Questions about playing or modding classic Daggerfall should be posted to Community.
Post Reply
Guitar18
Posts: 3
Joined: Sun May 24, 2020 9:49 am

[0.11.0] Missing music for Mages Guild

Post by Guitar18 »

So this one seems to be a minor bug, but I've noticed there seems to be a missing Mages Guild music track that does not play whenever entering a Mages Guild.

Tested in classic, this track (https://www.youtube.com/watch?v=qVCxHF7 ... -&index=35) titled 'Magic' sometimes plays (albeit not as often as the other Mages Guild track, which is included in Unity). However, after entering the Mages Guild repeatedly in Unity, it seems only one track plays in Mages Guilds.

Although not a major bug, it would be cool to see it featured in Unity to recreate that Classic Daggerfall feel and ambiance :D

User avatar
pango
Posts: 2749
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [0.11.0] Missing music for Mages Guild

Post by pango »

Well, the song is present, but MagesGuildSong case is not handled in SongManager.SelectCurrentSong(), so that's always the first song that's played. (that's also the case for CourtSongs, CastleSongs, InteriorSongs, PalaceSongs and ShopSongs but those lists contain only one song so that's fine, at least until somebody decides to mod more songs in).

Looks like an oversight, could be easy to fix but I don't know what's classic algorithm.
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Ferital
Posts: 252
Joined: Thu Apr 05, 2018 8:01 am

Re: [0.11.0] Missing music for Mages Guild

Post by Ferital »

I submitted a PR to fix this.

User avatar
pango
Posts: 2749
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [0.11.0] Missing music for Mages Guild

Post by pango »

Thanks Ferital!
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Post Reply