Page 1 of 1

[0.11.0] Missing music for Mages Guild

Posted: Tue Jan 12, 2021 3:17 pm
by Guitar18
So this one seems to be a minor bug, but I've noticed there seems to be a missing Mages Guild music track that does not play whenever entering a Mages Guild.

Tested in classic, this track (https://www.youtube.com/watch?v=qVCxHF7 ... -&index=35) titled 'Magic' sometimes plays (albeit not as often as the other Mages Guild track, which is included in Unity). However, after entering the Mages Guild repeatedly in Unity, it seems only one track plays in Mages Guilds.

Although not a major bug, it would be cool to see it featured in Unity to recreate that Classic Daggerfall feel and ambiance :D

Re: [0.11.0] Missing music for Mages Guild

Posted: Tue Jan 12, 2021 5:50 pm
by pango
Well, the song is present, but MagesGuildSong case is not handled in SongManager.SelectCurrentSong(), so that's always the first song that's played. (that's also the case for CourtSongs, CastleSongs, InteriorSongs, PalaceSongs and ShopSongs but those lists contain only one song so that's fine, at least until somebody decides to mod more songs in).

Looks like an oversight, could be easy to fix but I don't know what's classic algorithm.

Re: [0.11.0] Missing music for Mages Guild

Posted: Thu Jan 14, 2021 4:49 pm
by Ferital
I submitted a PR to fix this.

Re: [0.11.0] Missing music for Mages Guild

Posted: Thu Jan 14, 2021 6:02 pm
by pango
Thanks Ferital!