save game serialization fails with an exception sometimes [RESOLVED]

Locked
User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

save game serialization fails with an exception sometimes [RESOLVED]

Post by Nystul »

I managed to make the save game serialization fail with an exception somehow, see this screenshot:

Image

I am not sure how I did it - I did a dungeon run (entered a random dungeon and cleared it a bit) and then I wanted to save and got the exception and no new save game was created. I tried to debug into it, it seems to happen in line 532 of SaveLoadManager.cs coming from line 983 before.

bad news: have not found a way to reproduce it - I just wanted to let you know there might be an issue hidden somewhere

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: save game serialization fails with an exception sometimes

Post by Interkarma »

Cheers. Not sure on this one. Looking at the call stack, exception happened several calls deep into the guts of FullSerializer trying to convert a UInt64 to an Int64 value. SaveLoadManager line 532 is just invoking the serializer.

It will be sadly hard to diagnose without the live state, and could still be an issue with FullSerializer itself. I do a lot of saving in my tests, will keep eye open for it.

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: save game serialization fails with an exception sometimes

Post by Nystul »

Yeah I agree - will be hard to diagnose. We should just keep in mind that when someone encounters a situation where a save action won't result in a save game this issue could be responsible for it

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: save game serialization fails with an exception sometimes

Post by Nystul »

ok I think I have found a spot where it can be reproduced. Seems to have to do with clicking switches/levers and saving afterwards...
things to do to reproduce:
  • goto location "Isle of Balfiera/The Mausoleum of Darkivaron"
  • enter the dungeon
  • click the wheel on the left side of the entrance to the staircase
  • try to save

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: save game serialization fails with an exception sometimes

Post by Interkarma »

Perfect, thanks. :)

Will dive into this one when I can.

User avatar
Xaphir
Posts: 85
Joined: Sat Jul 16, 2016 12:55 pm

Re: save game serialization fails with an exception sometimes

Post by Xaphir »

Is this happening under doze or linux?

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: save game serialization fails with an exception sometimes

Post by Interkarma »

I'm assuming this will affect all platforms. Will do a deep dive on this to fix ahead of stable release.

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: save game serialization fails with an exception sometimes

Post by Interkarma »

This is fixed now and will be in next build.

Locked