[0.11.0] Minor bug in History page [RESOLVED 0.11.1]

Locked
13thsyndicate
Posts: 25
Joined: Sat Jul 25, 2020 5:53 pm

[0.11.0] Minor bug in History page [RESOLVED 0.11.1]

Post by 13thsyndicate »

So some of the background histories include you making friends with a person who is named several times in the entry... however,at least one version of the entry rerolls the name if not every time then several times throughout the entry. Not a huge priority but I don't think it's supposed to do that, might be a classic bug though, I don't remember very well.
Name glitch.jpg
Name glitch.jpg (520.67 KiB) Viewed 202 times
text bug 2.jpg
text bug 2.jpg (479.96 KiB) Viewed 202 times
This one does use the final name again to refer o the same person and it's reasonable that the three names listed could be three separate characters, but I've definitely encountered bios where this makes much less sense!

User avatar
Interkarma
Posts: 6019
Joined: Sun Mar 22, 2015 1:51 am

Re: [0.11.0] Minor bug in History page

Post by Interkarma »

Source text is using macro %fn which just generates a random name. We could easily make this deterministic when processing backstories, provided only a single NPC name like this is used for each backstory. Otherwise, all NPCs would end up with the same name, which is also a problem.

Definitely one to review, I'll move to bug reports for later follow up. Cheers. :)

User avatar
Ferital
Posts: 252
Joined: Thu Apr 05, 2018 8:01 am

Re: [0.11.0] Minor bug in History page

Post by Ferital »

I submitted a PR to fix this bug.

Locked