Completed quests not leaving active quest log.

[JorisVanEijden]

So i just completed 2 quests for fighter's guild. Well, one(kill a giant), but i found this merchant lady in the dungeon who wanted to be escorted to some place. So i killed the giant and escorted the lady to the location she wanted, i got thanks from her and i was hailed as giant slayer in the fighter's guild and got the reward. Problem is that the both quests are still in my active quest list and i cannot take a new quest from the guild.

Let's check with the quest source: https://github.com/Interkarma/daggerfal ... B00Y16.txt

I think `pc at _store_ set _S.13_` is not working as expected, or not used as intended.
It looks like DFU keeps updating _S.13_ even after it has triggered once. So when you leave the store it becomes false again. Which means that even though you complete the quest in _success_, _S.17_ is never set and the quest won't end.

Which didn't use to be a problem because the quest always ended even when it was not supposed to.
Since I fixed that in https://github.com/Interkarma/daggerfal ... f30b4123fc this new bug is exposed.

Personally I feel the `pc at` action should only trigger once. But I don't know if any other quests rely on the continuous behaviour. Either because the author interpreted the docs that way or because a classic quest was "fixed" to depend on the DFU behaviour.

I'm not sure what Interkarma wants.
Either change this quest to work with the DFU behaviour of PcAt, or dig deeper into the use of this action in other quests and modify the command.

[Interkarma]

No, "pc at" needs to work as designed. This has been soundly confirmed across several other classic quests. One great example is Sx977, which uses "pc at" to set/unset a variable when player enters/exits Daggerfall city. If that was only allowed to set once, then the haunting would continue even after player leaves Daggerfall city.

I've just made a simple fix to correct the logic error depending on S.13 staying active once set. This quest now completes normally no matter which order escort or hand-in to guild are performed.