Some faces not removed reliably from HUD by quests

Post here if you need help getting started with Daggerfall Unity or just want to clarify a potential bug. Questions about playing or modding classic Daggerfall should be posted to Community.
Post Reply
User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Some faces not removed reliably from HUD by quests

Post by pango »

Faces are removed from the HUD by

Code: Select all

drop _xxx_ face
using struct Equal method matching, but some fields can be filled with random values (for example for children), so matching may fail.

They're cleaned up when the quest is ended, but that's not satisfying

I guess Equal method could be overloaded, but what fields should be checked for match?
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Jay_H
Posts: 4072
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: Some faces not removed reliably from HUD by quests

Post by Jay_H »

Likely the same issue as here, but I don't mind a second topic: viewtopic.php?f=25&t=1098&p=39917#p37948

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Some faces not removed reliably from HUD by quests

Post by pango »

Ah yes, most likely the same bug
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Some faces not removed reliably from HUD by quests

Post by pango »

So, to rephrase my question, would a match on quest UID + a match on either targetPerson or targetFoe (their symbols) be enough to uniquely and reliably identify a face?
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7247
Joined: Sun Mar 22, 2015 1:51 am

Re: Some faces not removed reliably from HUD by quests

Post by Interkarma »

Yeah, that should do it. :)

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Some faces not removed reliably from HUD by quests

Post by pango »

I submitted a PR
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Post Reply