[0.10.24] Enemies And Unarmed Attacks Not Benefiting From Bonus Or Phobia Traits [RESOLVED 0.10.27]
Posted: Wed Jul 15, 2020 9:57 pm
So before I make a proper bug report, I would like to confirm if this is intended behavior or not.
So, while doing some testing for my combat overhaul mod, I noticed that the way the "GetBonusOrPenaltyByEnemyType" method in "FormulaHelper.cs" works is that only the player will ever be checked for having the "Bonus" or "Phobia" trait in their character career. While enemy entities, even human NPCs, like the Assassin, won't be checked for these traits. This includes the vampire and vampire ancient monsters.
The other thing is that the way "GetBonusOrPenaltyByEnemyType" is called, it only ever gets called if the attacker is using a weapon of some kind, otherwise it gets skipped by earlier. This means that unarmed attack of any kind, including from the player don't get factored in for the bonus or phobia check.
Is this intended? If not, i'll make a proper bug report post with more details.
So, while doing some testing for my combat overhaul mod, I noticed that the way the "GetBonusOrPenaltyByEnemyType" method in "FormulaHelper.cs" works is that only the player will ever be checked for having the "Bonus" or "Phobia" trait in their character career. While enemy entities, even human NPCs, like the Assassin, won't be checked for these traits. This includes the vampire and vampire ancient monsters.
The other thing is that the way "GetBonusOrPenaltyByEnemyType" is called, it only ever gets called if the attacker is using a weapon of some kind, otherwise it gets skipped by earlier. This means that unarmed attack of any kind, including from the player don't get factored in for the bonus or phobia check.
Is this intended? If not, i'll make a proper bug report post with more details.