Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised [RESOLVED 0.15.2]
- King of Worms
- Posts: 4754
- Joined: Mon Oct 17, 2016 11:18 pm
- Location: Scourg Barrow (CZ)
- Contact:
Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised [RESOLVED 0.15.2]
Yes, as crazy as this sounds, its true and THANKS GOD its pinpointed now
Some DREAM users reported very strange behavior, where parts of my mod were missing for them.
And just now EgoMaster from Nexus told me he found out the reason, Ive tested and he is right.
Go to Control Panel > Region > and than set this to Turkish(Turkey) Apply and run the game with DREAM enabled.
The videos will revert to vanilla, the DREAM HUD will be missing, Handheld will revert to vanilla, paperdoll will be vanilla - basically WHOLE DREAM MOD WILL BE COMPROMISED.
This most likely is not only limited to Turkish(Turkey) region, but many (all?) other regions than English (United States)
Im extremely relieved this bug is identified, as its apparently something so hard to pinpoint its a miracle it happened.
EDIT: Reverting back to English (United States) fixes the game back to working order.
Some DREAM users reported very strange behavior, where parts of my mod were missing for them.
And just now EgoMaster from Nexus told me he found out the reason, Ive tested and he is right.
Go to Control Panel > Region > and than set this to Turkish(Turkey) Apply and run the game with DREAM enabled.
The videos will revert to vanilla, the DREAM HUD will be missing, Handheld will revert to vanilla, paperdoll will be vanilla - basically WHOLE DREAM MOD WILL BE COMPROMISED.
This most likely is not only limited to Turkish(Turkey) region, but many (all?) other regions than English (United States)
Im extremely relieved this bug is identified, as its apparently something so hard to pinpoint its a miracle it happened.
EDIT: Reverting back to English (United States) fixes the game back to working order.
Last edited by King of Worms on Tue Feb 02, 2021 11:30 pm, edited 1 time in total.
DREAM Nexus https://www.nexusmods.com/users/73250038?tab=user+files
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
- TheLacus
- Posts: 1305
- Joined: Wed Sep 14, 2016 6:22 pm
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
Might be an issue with string comparison due to different locales. I'll move this topic to bug reports.
- King of Worms
- Posts: 4754
- Joined: Mon Oct 17, 2016 11:18 pm
- Location: Scourg Barrow (CZ)
- Contact:
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
Thanks
Very glad its identified, just double tested it and its definitely the case
Very glad its identified, just double tested it and its definitely the case
DREAM Nexus https://www.nexusmods.com/users/73250038?tab=user+files
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
- King of Worms
- Posts: 4754
- Joined: Mon Oct 17, 2016 11:18 pm
- Location: Scourg Barrow (CZ)
- Contact:
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
Any chance the fix gets in the next release? This renders basically all ppl who dont use English on their computers being unable to use Dream mod :X Thank you
DREAM Nexus https://www.nexusmods.com/users/73250038?tab=user+files
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
- Interkarma
- Posts: 7249
- Joined: Sun Mar 22, 2015 1:51 am
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
Hi KoW, the 0.11.1 builds are already cooked and will be dropped today/tomorrow. Any fix for this has missed the window.
When TheLacus has time to find problem, I'll be sure to merge that fix asap.
When TheLacus has time to find problem, I'll be sure to merge that fix asap.
- TheLacus
- Posts: 1305
- Joined: Wed Sep 14, 2016 6:22 pm
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
I can confirm this is the issue... fixed with #2045.
I suspect this might be related to issues with loading soundfont, but i haven't investigated further at this time.
- King of Worms
- Posts: 4754
- Joined: Mon Oct 17, 2016 11:18 pm
- Location: Scourg Barrow (CZ)
- Contact:
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
Thanks a lot Lacus
I do not understand the code changes but I saw the topic was named "Fix mod asset loading on turkish culture"
But this issue is more general. It bugs out on languages which use non-english signs, so probably many more languages than turkish. Just a heads up
I do not understand the code changes but I saw the topic was named "Fix mod asset loading on turkish culture"
But this issue is more general. It bugs out on languages which use non-english signs, so probably many more languages than turkish. Just a heads up
DREAM Nexus https://www.nexusmods.com/users/73250038?tab=user+files
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
- TheLacus
- Posts: 1305
- Joined: Wed Sep 14, 2016 6:22 pm
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
I believe it's actually limited to specific situations. I was able to replicate the issue with textures with an i in the name, which caused ambiguities when converting lower/upper case due to peculiarity of turkish language (ı/I and i/İ are different letters). Fix is not language specific, so any similar problem should also be solved.
- Interkarma
- Posts: 7249
- Joined: Sun Mar 22, 2015 1:51 am
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
Thanks for fixing, TheLacus!
Good point on the SoundFont issue being related. I note from that user's screenshots the system locale appears to be Turkish also (at least, text like "diskte boyutu" detects as Turkish in Google Translate). So very likely a similar problem with loading default SoundFont from Resources.
I'll leave this report open until I get a chance to look at that one. Cheers!
Good point on the SoundFont issue being related. I note from that user's screenshots the system locale appears to be Turkish also (at least, text like "diskte boyutu" detects as Turkish in Google Translate). So very likely a similar problem with loading default SoundFont from Resources.
I'll leave this report open until I get a chance to look at that one. Cheers!
- TheLacus
- Posts: 1305
- Joined: Wed Sep 14, 2016 6:22 pm
Re: Win 10 - When I set "region format" to Turkish (Turkey) 90% of the DREAM mod gets compromised
Is this the MIDI synthesizer? Might be the same issue with ToLower().
If that's the case it should be changed with id.Equals("riff", StringComparison.InvariantCultureIgnoreCase).
Code: Select all
string id = new string(IOHelper.Read8BitChars(reader, 4));
int size = reader.ReadInt32();
if (!id.ToLower().Equals("riff"))
throw new InvalidDataException("Invalid soundfont. Could not find RIFF header.");