Page 1 of 1

[0.13.5] Quest NPC names collision

Posted: Thu Apr 28, 2022 12:15 am
by pango
Seen in foxen stream, doing Azimuthal Vectors quest, Barbara Copperham is the scholar expert in Barbara Copperham's work:
Barbara Copperham expert.jpg
Barbara Copperham expert.jpg (95.61 KiB) Viewed 5387 times

Re: [0.13.5] Quest NPC names collision

Posted: Thu Dec 22, 2022 6:39 pm
by JorisVanEijden
How?

I mean, it's theoretically possible but it feels like it should be a bug.
The code looks okay to me, so it could have been coincidence?

I created a chnage that prevents duplicate npc names in quests: https://github.com/Interkarma/daggerfal ... _npc_names
But that doesn't really fix a bug, just makes sure that edge cases like this can't happen.

Re: [0.13.5] Quest NPC names collision

Posted: Thu Dec 22, 2022 9:02 pm
by BadLuckBurt
JorisVanEijden wrote: Thu Dec 22, 2022 6:39 pm How?

I mean, it's theoretically possible but it feels like it should be a bug.
The code looks okay to me, so it could have been coincidence?

I created a chnage that prevents duplicate npc names in quests: https://github.com/Interkarma/daggerfal ... _npc_names
But that doesn't really fix a bug, just makes sure that edge cases like this can't happen.
Preventing the edge case like you did should be all one needs to do in this situation. The nature of random doesn't exclude sameness from ever happening, for some people meeting their namesake has been a reality even on our planet so while rare, it's not impossible. I wouldn't really consider this a bug but more an undesired result if anything.

Re: [0.13.5] Quest NPC names collision

Posted: Fri Dec 23, 2022 5:18 pm
by JorisVanEijden
Yeah, I meant more that it's probably something for after the 1.0 release (if ever). I don't want to distract anyone with too many minor fixes or changes before then.