Forum Spoiler is not working following Quote

Off topic discussion. Talk about gaming and life in general. Be awesome to each other.
Post Reply
User avatar
TacticalTrickery
Posts: 36
Joined: Tue Jan 11, 2022 9:22 pm
Location: Shores of the Iliac
Contact:

Forum Spoiler is not working following Quote

Post by TacticalTrickery »

Hello, can we look into a small update to the forum's spoiler code please? :) ...this is pretty important, because it's crucial to lowering bandwidth in image-heavy posts.

It's not working whenever I see someone using it after a quote, as here:
whoeverUserBlahBlah wrote: fooBar...
Spoiler!
SPOILER FAIL HERE... can't click the button to show this line!
This Spoiler button fails. At least on Firefox.

Addt'l: Multiple spoiler buttons in one post result in clicked Spoiler buttons throughout the post toggling the 1st Spoiler on and off, rather than the one the user is clicking.

Here are some PHP code improvements we could utilize to perhaps quickly fix all of this, and even add a new Spoiler=titleHere] feature, for user-control of the "Spoiler!" word that appears to the left of the button. TT
ENEMY SPELLBOOK @Nexus: Yellow-square spam, be gone!!
Ancient African proverb: To go fast, go alone. To go far, go together. ~ Humanity's greatest strength is in each other... don't waste it.

User avatar
TacticalTrickery
Posts: 36
Joined: Tue Jan 11, 2022 9:22 pm
Location: Shores of the Iliac
Contact:

Re: Forum Spoiler is not working following Quote

Post by TacticalTrickery »

EXAMPLE: Works when b4 all uses of quote:

Spoiler!
Spoiler success here... can toggle me!
whoeverUserBlahBlah wrote: allYour...
ENEMY SPELLBOOK @Nexus: Yellow-square spam, be gone!!
Ancient African proverb: To go fast, go alone. To go far, go together. ~ Humanity's greatest strength is in each other... don't waste it.

User avatar
TacticalTrickery
Posts: 36
Joined: Tue Jan 11, 2022 9:22 pm
Location: Shores of the Iliac
Contact:

Re: Forum Spoiler is not working following Quote

Post by TacticalTrickery »

EXAMPLE: Fails with multiple uses of Spoilers.

Spoiler!
Spoiler success here... can toggle me! (...wait, am I being toggled from the other button too!?)
Only this 1st one will work.

Spoiler!
SPOILER FAIL HERE... can't click the button to show this line!
This Spoiler button fails.

Spoiler!
SPOILER FAIL HERE... can't click the button to show this line!
This Spoiler button fails too.
ENEMY SPELLBOOK @Nexus: Yellow-square spam, be gone!!
Ancient African proverb: To go fast, go alone. To go far, go together. ~ Humanity's greatest strength is in each other... don't waste it.

User avatar
BadLuckBurt
Posts: 948
Joined: Sun Nov 05, 2017 8:30 pm

Re: Forum Spoiler is not working following Quote

Post by BadLuckBurt »

That's a forum issue. I think it's been that way forever, the way those spoilers are implemented is just really crappy. Could be it's by design to stop people from spamming them in every post they make.
DFU on UESP: https://en.uesp.net/w/index.php?title=T ... fall_Unity
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt

.

User avatar
Jay_H
Posts: 4062
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: Forum Spoiler is not working following Quote

Post by Jay_H »

BadLuckBurt wrote: Thu Aug 25, 2022 10:45 am Could be it's by design to stop people from spamming them in every post they make.
That's one theory :lol: Actually better than what I theorized!

phpBB is free software without much expectation of investment. The forums will be ending at some point in the future, and I don't think investment to fix this will have a significant pay-off. Interkarma can correct me in that regard, but this is a problem better worked around rather than taking from DFU's development.

User avatar
TacticalTrickery
Posts: 36
Joined: Tue Jan 11, 2022 9:22 pm
Location: Shores of the Iliac
Contact:

Re: Forum Spoiler is not working following Quote

Post by TacticalTrickery »

Jay_H wrote: Thu Aug 25, 2022 11:15 am
BadLuckBurt wrote: Thu Aug 25, 2022 10:45 am Could be it's by design to stop people from spamming them in every post they make.
That's one theory :lol: Actually better than what I theorized!
:lol: you may be onto something with that.

Jay_H wrote: ...Interkarma can correct me in that regard, but this is a problem better worked around rather than taking from DFU's development.
Of course, wouldn't want to take from DFU dev, but in the phpBB link I shared in post-1, there are a few code-replacements contained in that short discussion. It looks like a 10minute fix that could save a great deal of bandwidth (server-side) and make complex forum posts far more digestible; a net positive for the project, naturally.
ENEMY SPELLBOOK @Nexus: Yellow-square spam, be gone!!
Ancient African proverb: To go fast, go alone. To go far, go together. ~ Humanity's greatest strength is in each other... don't waste it.

User avatar
BadLuckBurt
Posts: 948
Joined: Sun Nov 05, 2017 8:30 pm

Re: Forum Spoiler is not working following Quote

Post by BadLuckBurt »

TacticalTrickery wrote: Thu Aug 25, 2022 3:03 pm Of course, wouldn't want to take from DFU dev, but in the phpBB link I shared in post-1, there are a few code-replacements contained in that short discussion. It looks like a 10minute fix that could save a great deal of bandwidth (server-side) and make complex forum posts far more digestible; a net positive for the project, naturally.
I think the problem would be fixed by using the code from the second code box in this post: https://www.phpbb.com/community/viewtop ... #p15832561.

The inline Javascript makes me cringe but if it works it works.
DFU on UESP: https://en.uesp.net/w/index.php?title=T ... fall_Unity
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt

.

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Forum Spoiler is not working following Quote

Post by Interkarma »

Moving to Community as this is a discussion about the forums, not DFU support.

I'm more likely to remove this optional shortcode completely than spend any time hacking around in PHPBB's code to fix it. But I will take a look at Burt's link later and update shortcode if it helps things.

Post Reply