[0.15.3] Some paintings are broken (PAINT.DAT data)

[pango]

In a recent stream, Talonhatesnames couldn't "use" the Wayrest painting to demonstrate its magic nature to the audience.
After some debugging, it turns out it's not a regression, but some painting descriptions that cannot be generated (raise and exception), so it happened by "chance".

Debugging: InitPaintingInfo
message = 51714
-> paintingIndex = 70
->
paintingRecord = { 8, 14, 255, 255, 255, 255, 255, 255, 255, 255,
5, 8, 9, 255, 255, 255, 255, 255, 255, 255,
5, 8, 9, 255, 255, 255, 255, 255, 255, 255,
255, 255, 255, 255, 255, 255, 255, 255, 255, 255 }

Issue here is that all bytes in range 30 .. 39 are equal to 255, so GetPaintingRecordPart() gets no choice for %pp2 macro, and raises an exception, breaking interactions with the painting.
I think this is the only paintingIndex with that issue (out of 180).
I have no idea what classic does in that case.

[pango]

I submitted a PR

As noted, it's quite possible that classic does not generate text (= empty string) for the %pp2 macro that has no defined alternative. That would require adding special cases, though.

[Interkarma]

I love it when a bug report comes with a PR.

Good work tracking that down Pango. I appreciate the help, thank you!