You'll find a lot of unused flags and data inside the classic quests. I generally don't consider anything worth "fixing" unless it actually prevents the quest from being completed in a reasonable way. There are a lot of enhancements we could make by connecting existing dots, but that's really more of mod territory.
Jay_H wrote: ↑Mon Oct 30, 2023 10:21 pm
You'll find a lot of unused flags and data inside the classic quests. I generally don't consider anything worth "fixing" unless it actually prevents the quest from being completed in a reasonable way. There are a lot of enhancements we could make by connecting existing dots, but that's really more of mod territory.
And checking repute with undefined entity is totally fine and not breaking anything?
The quest action will ignore any non-existent Person resource, and doesn't cost anymore than a quick hashtable lookup to determine the named Person doesn't exist. It won't affect anything, but no reason it couldn't be cleaned up, it's an easy correction to make in this case.
Interkarma wrote: ↑Tue Oct 31, 2023 4:21 am
The quest action will ignore any non-existent Person resource, and doesn't cost anymore than a quick hashtable lookup to determine the named Person doesn't exist. It won't affect anything, but no reason it couldn't be cleaned up, it's an easy correction to make in this case.
Thanks. I changed _victin_ to _tguild_ in my translation. We'll see how it goes.