[0.16.2] No macro expansion in letter tooltip
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
[0.16.2] No macro expansion in letter tooltip
As seen in a TalonHatesNames' stream, the tooltip of a Dark Brotherhood warning doesn't have its macros expanded:
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Interkarma
- Posts: 7251
- Joined: Sun Mar 22, 2015 1:51 am
Re: [0.16.2] No macro expansion in letter tooltip
This is expected, macros are no longer expanded in quest letter tooltips.
https://github.com/Interkarma/daggerfal ... 541f335c69
Some macros require world lookups from location data and resulted in the game loading world just by user mousing around the inventory. This isn't very noticeable for unmodded game, but caused major stutters in games with heavily modded world data.
I have also limited tooltip to final line, which addresses the problem for letter in screenshot.
https://github.com/Interkarma/daggerfal ... 541f335c69
Some macros require world lookups from location data and resulted in the game loading world just by user mousing around the inventory. This isn't very noticeable for unmodded game, but caused major stutters in games with heavily modded world data.
I have also limited tooltip to final line, which addresses the problem for letter in screenshot.
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: [0.16.2] No macro expansion in letter tooltip
As seen on an TalonHatesNames stream, S0000010 letter has a broken tooltip.
Last line of the letter is sender name, not some location, so I don't know if that's the same limitation or an actual bug:
Last line of the letter is sender name, not some location, so I don't know if that's the same limitation or an actual bug:
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Kab the Bird Ranger
- Posts: 123
- Joined: Tue Feb 23, 2021 12:30 am
Re: [0.16.2] No macro expansion in letter tooltip
IK disabled all macro expansion in this tooltip, so it is the same issue.
I'm thinking we could probably replace macros with [...] for this tooltip. IK mentions that expanding them was too expensive, but not expanding them shows "debug" looking info.
I'm thinking we could probably replace macros with [...] for this tooltip. IK mentions that expanding them was too expensive, but not expanding them shows "debug" looking info.
- Interkarma
- Posts: 7251
- Joined: Sun Mar 22, 2015 1:51 am
Re: [0.16.2] No macro expansion in letter tooltip
I went a bit too far disabling all macros in tooltips, but at the time was feeling overwhelmed by things and that was the fastest fix.
The problem macros are specifically any that reference location data as these were triggering delays, especially in modded world data setups. Macros like the one in this tooltip (which is most of them) are perfectly fine.
A small refinement would be to allow all macros except the problematic location ones. A proper fix would be to find a way to prevent the mouseover lag for tooltips that require location data lookups.
The problem macros are specifically any that reference location data as these were triggering delays, especially in modded world data setups. Macros like the one in this tooltip (which is most of them) are perfectly fine.
A small refinement would be to allow all macros except the problematic location ones. A proper fix would be to find a way to prevent the mouseover lag for tooltips that require location data lookups.