Page 2 of 2
Re: [Feature request] Right-click to dismiss pop-up texts
Posted: Wed Feb 05, 2020 10:14 pm
by mikeprichard
Silence wrote: ↑Wed Feb 05, 2020 1:57 pm
mikeprichard wrote: ↑Tue Feb 04, 2020 11:09 pm
Unless I'm missing something, the current "Activate Center Object" control binding - the "right-click" vs. "left-click" / "click to attack" discussion being irrelevant - should always dismiss these pop-ups in base DFU. Anything else sounds like a bug, or at least extremely inconvenient/illogical behavior.
Yes, that is the point.
I would appreciate if someone could verify the bug, because right now I'm doubting myself (or rather, my keybinding setup) and I don't have DFU at hand. Also, peer review, and that.
OK - the "Right-Click" in your topic title was just misleading, as was some of the discussion around that. Unfortunately, I can't test this right now, but it would be great to see a fix here as warranted.
Re: [Feature request] Right-click to dismiss pop-up texts
Posted: Thu Feb 06, 2020 7:18 pm
by pango
I submitted a
PR
Dialog boxen can be closed using Return key, but many dialog boxen are also configured with clickAnywhereToClose = true, so can be closed by just clicking a mouse button (actually, the left mouse button only). It does not depend on bindings.
This PR extends this mechanism so you can use any button (left, right or middle), but the one used to swing your weapon.
Re: [Feature request] Right-click to dismiss pop-up texts
Posted: Sun Feb 16, 2020 10:59 am
by Silence
Awesome! Thanks!
Re: [Feature request] Right-click to dismiss pop-up texts
Posted: Sun Feb 16, 2020 11:03 am
by pango
I just hope it's not too counter-intuitive for people that chose to use the left mouse button for attacking...
Re: [Feature request] Right-click to dismiss pop-up texts
Posted: Mon Feb 17, 2020 4:03 pm
by Silence
It may cause some to pause when they meet one of these pop-ups for the first time, but in that situation most of us would try pressing several keys to see which one will make the scroll go away, and eventually find it out. People who have the layout remapped already are prone to explore their options, I would assume.
The alternative — missing a bit of relevant text in the middle of a fight — is, I would argue, worse.