Page 3 of 3

Re: Base DFU feature request - buying items won't automatically equip them

Posted: Fri Feb 05, 2021 6:02 pm
by Hazelnut
pango wrote: Fri Feb 05, 2021 5:09 pm I'm fine with this change to inventory.
So, just to be clear, it will also apply to shopping, left click = equip, right click = just add to inventory?
Yes, exactly. Will take maybe 15-20 mins to implement and test.

Re: Base DFU feature request - buying items won't automatically equip them

Posted: Fri Feb 05, 2021 10:05 pm
by GeeTee
Hazelnut wrote: Fri Feb 05, 2021 4:15 pm Implementing this behaviour would be very easy to do and I am happy to do this..
Fantastic! Glad to hear it :D
pango wrote: Fri Feb 05, 2021 5:09 pm ... it will also apply to shopping, left click = equip, right click = just add to inventory?
I agree with this approach, the current LMB action should remain unchanged to preserve default behaviour.

Re: Base DFU feature request - buying items won't automatically equip them

Posted: Tue Feb 09, 2021 11:04 pm
by jefetienne
Hazelnut wrote: Fri Feb 05, 2021 4:15 pm To do this it will require moving the functionality currently on right click that's to cycle visual variants (mainly for clothes) which is a DFU QoL addition I believe. I would move this to middle mouse click (press scroll wheel) so that right click would work as described in the DF manual.

Any opinions on this? Especially from Interkarma and the other devs.
As the person who made that QoL, it sounds fine to me. In this case, I might need to add middle click keybind for controller support since a person can only map left and right clicks at the moment.

Re: Base DFU feature request - buying items won't automatically equip them

Posted: Sat Feb 13, 2021 7:04 pm
by Hazelnut
Thanks Jefetienne. I will go ahead and submit a PR for Interkarma to close or merge as I don't think he's going to say either way on this thread. Shouldn't take long to do.

PR#2032 submitted. Please test it in case I missed an edge case anywhere.

Re: Base DFU feature request - buying items won't automatically equip them

Posted: Sun Feb 14, 2021 12:05 am
by jefetienne
Sure thing, I'll go ahead and take a look tonight. Thanks!