Help me assign clothing archive numbers to the race

Discuss modding questions and implementation details.
User avatar
Hazelnut
Posts: 2223
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Help me assign clothing archive numbers to the race

Post by Hazelnut » Sun Mar 22, 2020 7:57 pm

Possible that this was missed, I'll look into it and compare with classic.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Hazelnut
Posts: 2223
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Help me assign clothing archive numbers to the race

Post by Hazelnut » Sun Mar 22, 2020 8:48 pm

Well I'll be, you're right. There's not much difference so it's hardly surprising this was not noticed before.

I can only really see differences for short bow, war axe and war hammer. Here's a comparison of a female character holding a war axe. Current code uses archive 234 show at the top, and using archive 233 shown below.
weaponGender.png
weaponGender.png (30.14 KiB) Viewed 339 times
I also confirmed that classic uses archive 233 for females and I feel confident that this is an oversight. I will submit a PR.

Great theory KoW. Hope this doesn't cause you too much extra work having removed the 233 images.

This will cause my code for new weapons some issues, darn it. :D
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
King of Worms
Posts: 3213
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Help me assign clothing archive numbers to the race

Post by King of Worms » Sun Mar 22, 2020 9:11 pm

Hey Im very glad we found this bug, that was well hidden one :)

I found a backup of those 233 archive files. I will just have to create new xml files for it. Once done, it will be a joy to finally have all weapons correctly in hands for all characters

Eitherway - its great to have separate archives now, and that the base game gets improved for everyone

User avatar
Hazelnut
Posts: 2223
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Help me assign clothing archive numbers to the race

Post by Hazelnut » Sun Mar 22, 2020 10:30 pm

Yeah, me too. Nice work there, this probably should have occurred to me when you asked the question about whether 233 was actually used. But it didn't, that's how much trust I generally have in the work done by others to recreate DF, and it does have quite a large number of weird things so I just assumed it was another oddness.

Took a bit of time to ensure it works with my new items which are going to use the same images for both genders since they are both 1 handers. Looking at the differences between 233 & 234, it's only really 2 handed weapons that are different.

This fix is going into my PR for custom items as I wanted to ensure it was fully working with that code.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
King of Worms
Posts: 3213
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Help me assign clothing archive numbers to the race

Post by King of Worms » Tue Mar 24, 2020 4:32 pm

Just to be sure, the new female weapons archive and the console command for spawning clothing will be in the next release?
Is there any way I can get to that earlier? To be able to setup the new archive sprite positions with XML files.
And to test the clothing I was not able to spawn previously.

Thanks :)

User avatar
Hazelnut
Posts: 2223
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Help me assign clothing archive numbers to the race

Post by Hazelnut » Tue Mar 24, 2020 5:23 pm

The way I implemented it is the weapon items remain unchanged and continue to use archive 234 for inventory, only when player equips does it now use the correct archive for females so offsets etc are correct.

If you want to test early you can clone my branch from here into a new folder and open in unity: https://github.com/ajrb/daggerfall-unit ... ustomItems

The corrections for add_all_equip are in there and are already merged for the next release.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
King of Worms
Posts: 3213
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Help me assign clothing archive numbers to the race

Post by King of Worms » Tue Mar 24, 2020 9:01 pm

Thank you for the update, I will try the branch you linked, if Im able to make it run . )

User avatar
King of Worms
Posts: 3213
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Help me assign clothing archive numbers to the race

Post by King of Worms » Tue Apr 07, 2020 3:50 pm

Mate, that 233 archive is not working.

When I place those files as a loose file in the streaming assets/textures, they do not appear in the game :X

So to me it seems that it was not implemented?

PS: The spawning command works indeed, seen some clothing Ive never seen spawned before, thank you :)

User avatar
Hazelnut
Posts: 2223
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Help me assign clothing archive numbers to the race

Post by Hazelnut » Wed Apr 08, 2020 9:33 am

That change didn't get in the build, sorry. Next one I hope... it's part of the custom items PR.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
King of Worms
Posts: 3213
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Help me assign clothing archive numbers to the race

Post by King of Worms » Wed Apr 08, 2020 9:40 am

Hazelnut wrote:
Wed Apr 08, 2020 9:33 am
That change didn't get in the build, sorry. Next one I hope... it's part of the custom items PR.
Ok no worries.. well I will just release DREAM with that archive and hope it doesnt get totally messed up with next DFU release... if it does, I will release a hotfix with just the xml files. Thanks for confirmation

Post Reply