Need Others Help

[l3lessed]

Hey Everyone, I'm working on creating a patch script file for my shield module, so it can work with other mods that use the attack formula override. However, I do not know every mod that has been released that touches this formula override.

Could everyone help me by just posting any mods they have used or developed that you know touch the CalculateAttackDamage formula override?

If you're unsure what object I'm speaking of, it's this routine used to calculate damage and return it to the engine.

Code: Select all

public static int CalculateAttackDamage(DaggerfallEntity attacker, DaggerfallEntity target, int enemyAnimStateRecord, int weaponAnimTime, DaggerfallUnityItem weapon)

I'm overriding it using the built in override method, and I need to ensure compatibility with mods that touch it too.

Code: Select all

FormulaHelper.RegisterOverride(ShieldFormulaHelper.ShieldFormulaHelperInstance, "CalculateAttackDamage", (Func<DaggerfallEntity, DaggerfallEntity, int, int, DaggerfallUnityItem, int>)ShieldFormulaHelper.CalculateAttackDamage);

[Ralzar]

As I just posted in Magiconos thread. I made a PR for his mod specifically to make it work with the new chainmail armors in RP&R:Items.

https://github.com/magicono43/DFU-Mod_P ... aul/pull/1

[jefetienne]

My Harderfall Mod primarily touches this very method, but I wouldn't want to aim for compatibility with it due its simplicity.

[l3lessed]

I would think your users would want it even more. 100% hit chance would make shield all the more important.

You sure you don't want to patch for it? It literally is adding one script and its namespace, and then dropping in one block of code into a new formula-override method and activating it if my mod is detected.

If you don't want to, can I include a patch in my mode for it? It will make your mod not needed though, since it will just replicate defaulting hit chance to 100% every time in the formula. As you said, super simple. I just want to ensure I'm not taking other modder's work and users, as I know how much effort goes into this stuff.

[l3lessed]

By the way, your documentation/repo use is excellent ralzar. I got to get my stuff in order like yours.

[jefetienne]

I would think your users would want it even more. 100% hit chance would make shield all the more important.

You sure you don't want to patch for it? It literally is adding one script and its namespace, and then dropping in one block of code into a new formula-override method and activating it if my mod is detected.

If you don't want to, can I include a patch in my mode for it? It will make your mode not needed though, since it will just replicate defaulting hit chance to 100% every time in the formula. As you said, super simple. I just want to ensure I'm not taking other modders work and users, as I know how much effort goes into this stuff.

Sure thing, I'll patch it and yes you can also include the patch for your mode as well. If the code I write for the engine is licensed under MIT, so is the code for my mods (unless stated otherwise).

[Ralzar]

By the way, your documentation/repo use is excellent ralzar. I got to get my stuff in order like yours.

Would you believe it's all through the web browser and drag-n-drop?

Whenever I update the nexus file I drag-n-drop the same script files into my repository.

[Hazelnut]

By the way, your documentation/repo use is excellent ralzar. I got to get my stuff in order like yours.

Would you believe it's all through the web browser and drag-n-drop?

Whenever I update the nexus file I drag-n-drop the same script files into my repository.

Urgh, It works I know, but commits and pushes are really easy with GitHub desktop.. then you get a much better code history.

(am I becoming a nag, Ral? )

[Ralzar]

(am I becoming a nag, Ral? )

(Always Hazel )