Selling horses & carts

Discuss coding questions, pull requests, and implementation details.
User avatar
jayhova
Posts: 297
Joined: Wed Jul 19, 2017 7:54 pm
Contact:

Re: Selling horses & carts

Post by jayhova » Tue Apr 16, 2019 4:16 am

Maybe you are desperate for money. Maybe as an element of roleplay. Who knows. If the player really wants to sell his cart let him. Maybe that one item is what you need to get your merchant skill up. :-)
Remember always 'What would Julian Do?'.

User avatar
Jay_H
Posts: 2005
Joined: Tue Aug 25, 2015 1:54 am

Re: Selling horses & carts

Post by Jay_H » Tue Apr 16, 2019 4:32 am

This still leaves the question of what to do when the cart has items, though. Should they all just disappear? Or hang around in the void until a player buys another wagon?
Try the first Daggerfall Unity Quest Pack with roughly 210 all-new quests.
I write quests but have no technical knowledge.

User avatar
pango
Posts: 868
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Selling horses & carts

Post by pango » Tue Apr 16, 2019 6:21 am

The "wagon" button doesn't allow to specify which cart to use, so I see two options:
  • we allow to use all the carts you have, wagon capacity grows with the number of carts. Assuming you pack your stuff in the minimum number of carts needed, the others are empty and sellable. Beside implementation difficulty (are items assigned to carts, or are we just using n * 750kg as wagon capacity?), this option is the most likely to break game balance;
  • only allow to fill one cart, others stay empty. In which case we can sell all but one cart, and maybe sell the last one only if it's empty.
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

BansheeXYZ
Posts: 268
Joined: Fri Oct 23, 2015 8:19 pm

Re: Selling horses & carts

Post by BansheeXYZ » Tue Apr 16, 2019 11:46 am

pango wrote:
Tue Apr 16, 2019 6:21 am
The "wagon" button doesn't allow to specify which cart to use, so I see two options:
  • we allow to use all the carts you have, wagon capacity grows with the number of carts. Assuming you pack your stuff in the minimum number of carts needed, the others are empty and sellable. Beside implementation difficulty (are items assigned to carts, or are we just using n * 750kg as wagon capacity?), this option is the most likely to break game balance;
  • only allow to fill one cart, others stay empty. In which case we can sell all but one cart, and maybe sell the last one only if it's empty.
Or... disallow ownership of more than 1 cart/horse/spellbook. The game really wasn't designed for selecting between duplicates of those things. And having endless carts seems like cheating, plus it ruins the point of buying a house.

User avatar
jayhova
Posts: 297
Joined: Wed Jul 19, 2017 7:54 pm
Contact:

Re: Selling horses & carts

Post by jayhova » Tue Apr 16, 2019 3:16 pm

One good reason to allow the selling of a horse and wagon is so the PC can steal another one. I think the idea of only allowing a wagon to be sold if it is empty is correct. It would be convenient if all the stuff got moved into your personal inventory automatically. As to buying a horse if you already have one it seems like the easy solution is to just remove the horse and/or wagon from the items for sale or ghost them out in the items for sale UI.
Remember always 'What would Julian Do?'.

User avatar
pango
Posts: 868
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Selling horses & carts

Post by pango » Tue Apr 16, 2019 7:31 pm

I created a PR
"Allow to sell horses and wagons.
If you have items in your wagon, one arbitrary wagon cannot be sold."

Feel free to test it, the inventory is used in a lot of contexts, I hope I forgot no loophole...
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Hazelnut
Posts: 1147
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Selling horses & carts

Post by Hazelnut » Thu Apr 18, 2019 3:09 pm

BansheeXYZ wrote:
Tue Apr 16, 2019 11:46 am
pango wrote:
Tue Apr 16, 2019 6:21 am
The "wagon" button doesn't allow to specify which cart to use, so I see two options:
  • we allow to use all the carts you have, wagon capacity grows with the number of carts. Assuming you pack your stuff in the minimum number of carts needed, the others are empty and sellable. Beside implementation difficulty (are items assigned to carts, or are we just using n * 750kg as wagon capacity?), this option is the most likely to break game balance;
  • only allow to fill one cart, others stay empty. In which case we can sell all but one cart, and maybe sell the last one only if it's empty.
Or... disallow ownership of more than 1 cart/horse/spellbook. The game really wasn't designed for selecting between duplicates of those things. And having endless carts seems like cheating, plus it ruins the point of buying a house.
I think this would be the right approach. I will admit to not considering the possibility of people stealing multiple carts... :roll:

So, ensure player can only have a single horse and single cart, then nothing else is required. Selling them is a bit pointless IMO, but I suppose if people want that for RP value it could be added.

Post Reply