Notebook implementation

Discuss coding questions, pull requests, and implementation details.
User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Notebook implementation

Post by Nystul »

What happens to failed quest? Do they show up on the notebook? If yes, are they somehow marked as failed?

Is it possible to delete finished quest entries purposely?

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Notebook implementation

Post by Hazelnut »

Yes all quests are added, with no indication regarding outcome. I simply copy the entries from current quest tab when quest ends. Yes, you can delete entries and reorder them, but I think that might be a good idea to indicate failed quests. I'll take a look at doing that.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Notebook implementation

Post by Hazelnut »

Have submitted a PR that gives white headings for finished quests which includes whether you completed it or failed. Should be in next build hopefully.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Jay_H
Posts: 4061
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: Notebook implementation

Post by Jay_H »

Image

You modern kids with your fancy 40" screens and your 1028x resolutions! :P My screen's too small to handle this text.

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Notebook implementation

Post by Hazelnut »

Hey you can see enough to know what to do right? :D

What resolution were you using there Jay?
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Notebook implementation

Post by Interkarma »

Just wrapping or removing that final line should do it. It's the one pushing out the width so much.

Can probably do without that final line IMO. It doesn't seem to communicate anything that essential after you've used the feature at least once. :)

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Notebook implementation

Post by Hazelnut »

I've reduced the length so it's not too wide for smaller resolutions.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Notebook implementation

Post by Nystul »

I like that the location now is part of the title - although I would also vote for the region (province) as it is not clear to the player in what region the location is in

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Notebook implementation

Post by Hazelnut »

Nystul wrote: Tue Oct 30, 2018 2:16 pm I like that the location now is part of the title - although I would also vote for the region (province) as it is not clear to the player in what region the location is in
Yes, I know. I put that in at first but had to reduce the length to fit the journal so that headings don't wrap onto a second line, which is quite important. Unfortunately, this was the first thing to go. I did add regions to map note entries though, and also if you're not in a location (town/dungeon etc) then it will just have the region name.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Notebook implementation

Post by Nystul »

ah nice, I like this

Post Reply