I've worked through the effect system status page to update Special Advantage/Disadvantages to reflect what has been completed so far (scroll down to bottom third of page linked). Majority of these are implemented in FormulaHelper.cs and were easy to see are now active, and I think I've accurately reflected completed state of these items.
I was hoping the other devs involved with formula work (especially Allofich and Hazelnut) could quickly double-check the items I've marked complete and let me know if I've forgotten anything or marked something complete that shouldn't be.
Cheers!
Effect System Roadmap Checkup
- pango
- Posts: 3347
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Effect System Roadmap Checkup
Shouldn't Pacify effects have a duration?
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Jay_H
- Posts: 4062
- Joined: Tue Aug 25, 2015 1:54 am
- Contact:
Re: Effect System Roadmap Checkup
In classic it only used Chance. Looks like it was intended to be permanent.
- pango
- Posts: 3347
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Effect System Roadmap Checkup
That's what happens when I check the UESP instead of the game
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Interkarma
- Posts: 7236
- Joined: Sun Mar 22, 2015 1:51 am
Re: Effect System Roadmap Checkup
All "Special Advantages" and "Special Disadvantages" should now be functional in live code. Many of these are delivered through various active systems (e.g. combat formulae), and some through the PassiveSpecialsEffect uber-effect class permanently attached to player entity.
Please let me know if any of these should be assigned a different completion status. I'm otherwise moving on to magic item powers and side-effects now.
Please let me know if any of these should be assigned a different completion status. I'm otherwise moving on to magic item powers and side-effects now.
- pango
- Posts: 3347
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Effect System Roadmap Checkup
You can't tweak the chance of success of Identify; It seems you could in classic.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Jay_H
- Posts: 4062
- Joined: Tue Aug 25, 2015 1:54 am
- Contact:
Re: Effect System Roadmap Checkup
Yeah, that's the player-based Identify effect which Interkarma hasn't implemented yet. For now, as a simple solution, he just implemented the store-based Identify effect. Later on he'll add the player one.
- Interkarma
- Posts: 7236
- Joined: Sun Mar 22, 2015 1:51 am
Re: Effect System Roadmap Checkup
Yeah, I need to loop back to this one soon. Thank you for the reminder Pango.
- Teralitha
- Posts: 359
- Joined: Wed Jul 17, 2019 3:44 pm
Re: Effect System Roadmap Checkup
So whats the success chance for the spell currently? 100%?
- Jay_H
- Posts: 4062
- Joined: Tue Aug 25, 2015 1:54 am
- Contact:
Re: Effect System Roadmap Checkup
For now, yeah. It's the same as using the store version.