Page 1 of 1

Effect System Roadmap Checkup

Posted: Thu Jan 03, 2019 10:52 pm
by Interkarma
I've worked through the effect system status page to update Special Advantage/Disadvantages to reflect what has been completed so far (scroll down to bottom third of page linked). Majority of these are implemented in FormulaHelper.cs and were easy to see are now active, and I think I've accurately reflected completed state of these items.

I was hoping the other devs involved with formula work (especially Allofich and Hazelnut) could quickly double-check the items I've marked complete and let me know if I've forgotten anything or marked something complete that shouldn't be.

Cheers!

Re: Effect System Roadmap Checkup

Posted: Sun Jan 06, 2019 4:38 am
by pango
Shouldn't Pacify effects have a duration?

Re: Effect System Roadmap Checkup

Posted: Sun Jan 06, 2019 4:58 am
by Jay_H
In classic it only used Chance. Looks like it was intended to be permanent.

Re: Effect System Roadmap Checkup

Posted: Sun Jan 06, 2019 6:20 am
by pango
That's what happens when I check the UESP instead of the game :oops:

Re: Effect System Roadmap Checkup

Posted: Wed Jan 09, 2019 5:56 am
by Interkarma
All "Special Advantages" and "Special Disadvantages" should now be functional in live code. Many of these are delivered through various active systems (e.g. combat formulae), and some through the PassiveSpecialsEffect uber-effect class permanently attached to player entity.

Please let me know if any of these should be assigned a different completion status. I'm otherwise moving on to magic item powers and side-effects now.

Re: Effect System Roadmap Checkup

Posted: Fri Mar 01, 2019 7:46 pm
by pango
You can't tweak the chance of success of Identify; It seems you could in classic.

Re: Effect System Roadmap Checkup

Posted: Fri Mar 01, 2019 9:30 pm
by Jay_H
Yeah, that's the player-based Identify effect which Interkarma hasn't implemented yet. For now, as a simple solution, he just implemented the store-based Identify effect. Later on he'll add the player one.

Re: Effect System Roadmap Checkup

Posted: Sat Mar 02, 2019 1:55 am
by Interkarma
Yeah, I need to loop back to this one soon. Thank you for the reminder Pango. :)