implementation of talk window

Discuss coding questions, pull requests, and implementation details.
Post Reply
User avatar
Interkarma
Posts: 5183
Joined: Sun Mar 22, 2015 1:51 am

Re: implementation of talk window

Post by Interkarma » Sun Jun 03, 2018 12:28 pm

Improvements to this are on git now. I was forgetting the SetAssignedPlaceSymbol() call after placing Person from "create npc".

However only two of the four are showing up for some reason. I can confirm all _friend1-4_ had their lastAssignedPlaceSymbol set to their home Place symbol when "create npc" was called. Not sure if this is on my end on yours and too tired to dig in any further. :)

Here's a screenshot with a couple of these NPCs now visible from "create npc". The top one is the actual questor who was already showing up before this change.
two-of-four.jpg
two-of-four.jpg (128.66 KiB) Viewed 1041 times

One more thing. I've added a public boolean property to to Person resource called DiscoveredThroughTalkManager. I thought you might be able to use this to get/set when a Person has been revealed through talk system. This is serialized with the Person resource as expected.

Not sure if this will be helpful at all. If not, I'll just remove it again later and we can look at a better solution for you. :)

User avatar
Nystul
Posts: 1394
Joined: Mon Mar 23, 2015 8:31 am

Re: implementation of talk window

Post by Nystul » Sun Jun 03, 2018 7:06 pm

2 out of 4 being available is correct, the other two are hidden by dialog link command.
The hidden ones should become available when pc learns about them in answer messages given by the first two. Though this might be broken at the moment. Cannot test at the moment though

User avatar
Hazelnut
Posts: 2129
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: implementation of talk window

Post by Hazelnut » Sun Jun 03, 2018 7:55 pm

Looks like you guys have been rather busy this weekend, great progress from what I gather from reading the thread.

Interkarma, can't recall when or in what context we discussed this (prob. in a PR on github) but this was the thing where I'd added some code into person.cs (was commit 29 march) to get the DB joining quest to work a bit more than it did, but while the NPC was auto added to the correct type of building still differed from classic in that it was not an existing NPC - i.e. shopkeeper. I think from reading that this will now be fixed, but I thought I would mention in case it's helpful.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Interkarma
Posts: 5183
Joined: Sun Mar 22, 2015 1:51 am

Re: implementation of talk window

Post by Interkarma » Sun Jun 03, 2018 8:53 pm

Nystul, of course! Sorry didn't consider the dialog link. My brain was melting by that point. :)

Thanks Hazelnut. I'm hoping that all still works in a way the player can complete quest. I tried to make improvements as well for local building support. I haven't tested DB joining yet since the change though.

User avatar
Jay_H
Posts: 3145
Joined: Tue Aug 25, 2015 1:54 am

Re: implementation of talk window

Post by Jay_H » Sun Sep 09, 2018 2:26 am

My talk window doesn't recognize %pcf as the PC's name, and just prints %pcf in each case. Is this an undiscovered bug?
Come join Lysandus' Tomb, a Daggerfall Unity fan Discord.
See the Daggerfall Unity Wiki on the UESP.

User avatar
Nystul
Posts: 1394
Joined: Mon Mar 23, 2015 8:31 am

Re: implementation of talk window

Post by Nystul » Sun Sep 09, 2018 8:30 am

This worked in the past. Unfortunately there seem to be several regression bugs due to contributions recently. E.g. It is currently not possible to talk to the npcs in orsinium dungeon and scourg barrow. Unrelated to talk window other things are broken as well like fog settings being changed repeatedly to hardcoded values and thus breaking mods. My plan is to fix those issues one at a time but I can not give a date when this will happen since my time is limited at the moment.

User avatar
Interkarma
Posts: 5183
Joined: Sun Mar 22, 2015 1:51 am

Re: implementation of talk window

Post by Interkarma » Sun Sep 09, 2018 12:40 pm

What's the issue with NPCs in Orsinium and Scourg? I'm about to head to bed, and can't look at this until tomorrow.

I'm happy to help though if it gets the problem fixed sooner. I wasn't aware of these ones.

Thanks for the heads up. :)

User avatar
Nystul
Posts: 1394
Joined: Mon Mar 23, 2015 8:31 am

Re: implementation of talk window

Post by Nystul » Sun Sep 09, 2018 5:38 pm

Interkarma wrote:
Sun Sep 09, 2018 12:40 pm
What's the issue with NPCs in Orsinium and Scourg? I'm about to head to bed, and can't look at this until tomorrow.

I'm happy to help though if it gets the problem fixed sooner. I wasn't aware of these ones.

Thanks for the heads up. :)
an exception is thrown in GetReactionToPlayer function - I guess it is not a big issue ;) just wanted to point out that regression bugs are coming up faster than I am able to spend time on fixing them right now - but no big deal ;)

currently I am working on sdf font rendering on exterior automap.

User avatar
Interkarma
Posts: 5183
Joined: Sun Mar 22, 2015 1:51 am

Re: implementation of talk window

Post by Interkarma » Sun Sep 09, 2018 9:18 pm

Nystul wrote:
Sun Sep 09, 2018 5:38 pm
an exception is thrown in GetReactionToPlayer function - I guess it is not a big issue ;) just wanted to point out that regression bugs are coming up faster than I am able to spend time on fixing them right now - but no big deal ;)

currently I am working on sdf font rendering on exterior automap.
Thanks for letting me know. This issue came up now that faction data is all 0-based. I tried to find all the cases where this could go wrong, but had forgotten about this property. Fixed now, and hopefully that's the only real glitch after that change. :)

Let me know if any help needed with the SDF stuff.

User avatar
Nystul
Posts: 1394
Joined: Mon Mar 23, 2015 8:31 am

Re: implementation of talk window

Post by Nystul » Mon Sep 10, 2018 5:21 am

Thank you :)

Post Reply