Build #105 - Guild membership lost [RESOLVED]

Report specific bugs in Daggerfall Unity. Please read guidelines before posting.
User avatar
Interkarma
Posts: 3036
Joined: Sun Mar 22, 2015 1:51 am

Build #105 - Guild membership lost [RESOLVED]

Post by Interkarma » Fri Apr 20, 2018 11:11 pm

This was reported by someone on Twitter. I've been able to reproduce fairly reliably in the following manner:
  1. Join Fighters Guild (I was working out of Gothway Garden)
  2. Take an out of town quest (e.g. kill animal in a remote town)
  3. Travel to remote town and complete quest.
  4. Return back to original town and enter town limits. Immediately save and exit game.
  5. Reopen game, loading previous save.
  6. Return to quest giver in Fighters Guild.
  7. Player is no longer a member of guild and membership is offered again. If you save game again at this point, previous guild membership is wiped from "guildMemberships" structure in save data.
already-member.jpg
already-member.jpg (66.37 KiB) Viewed 682 times
I've also attached a save immediately after returning to town and saving (at step 5). Player is currently a member of Fighters with the current "guildMemberships" data.

Code: Select all

            "guildMemberships": [
            {
                "Key": 11,
                "Value": {
                    "rank": 1,
                    "lastRankChange": 147162,
                    "variant": 0,
                    "flags": 0,
                    "$version": "v1"
                }
            }
        ],
        "$version": "v1"
If you loiter until after 11pm then enter Fighters, you'll no longer be a member when talking to the quest guy.
Attachments
SAVE249.zip
(146.36 KiB) Downloaded 10 times

User avatar
Hazelnut
Posts: 596
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build #105 - Guild membership lost

Post by Hazelnut » Fri Apr 27, 2018 5:30 pm

I had this problem myself, but I can't recall if I tracked it down or not... suspect not, either that or this is a different issue.

Bit out of touch with DFU at the moment, work has been crazy. Been in Romania this week. Anyway I will try to take a look when I can.

User avatar
Midknightprince
Posts: 664
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Build #105 - Guild membership lost

Post by Midknightprince » Sat Apr 28, 2018 2:30 am

I can confirm this one.
For me, I got the quest, headed to location, save the game, and quit.
Load game, stopped off at another FG to rest for the night before getting to quest location (kill animals on farm, sabertooths).
But I was no longer a member, but quest was still going in log.
So I re-join at that second guild, go on to finnish the quest, go back to first one where I got the quest, and done= 5 rep (this was last night).
So I reload the game after reading this post to see what's going on and this is where it gets weird.
The game I loaded after quest completion= no Guild membership, I reload the game while on quest, at second fighters guild= im in guild quest is active, and I can get quests from second guy, I then reload first save again without quiting, and I'm in guild with 5 rep again..
I can duplicate this..
Check out my YouTube Channel!

User avatar
Midknightprince
Posts: 664
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Build #105 - Guild membership lost

Post by Midknightprince » Sat Apr 28, 2018 2:40 am

Saving game again, after getting the affiliation to show up on my first game like it should, quiting, and reloading dident fix it, lemmi start a quest, finnish it, save, and load, see what happens.
If I'm in, and with rep, maybe something is happening with saves...
Check out my YouTube Channel!

User avatar
Midknightprince
Posts: 664
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Build #105 - Guild membership lost

Post by Midknightprince » Sat Apr 28, 2018 3:14 am

Seems to be saves outside (not in interiors).
Heres what I did, made 3 saves after finnishing quest, 1 in FG, 1 outside, 1 in an inn after resting.
1, and 3= rep saved=10.
2 no rep, no guild memb, and I can load 1, or 3 with rep, then load 2 (outside), and it fixes it.
Also, after getting rep to show up in 2, if I save that game INDOORS, rep works from a fresh load, so no saving outdoors if you wana be in FG for now (thats the only one I've messed with)..
Actually, just dont do a fresh load outdoors, only interiors...
Loading during gameplay doesn't seem to be the problem....
Check out my YouTube Channel!

User avatar
Midknightprince
Posts: 664
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Build #105 - Guild membership lost

Post by Midknightprince » Sat Apr 28, 2018 9:16 pm

Yep, its just saving outside.
Played last night, saved durring a quest inside, on the farm quest.
Still got my rep, and im on the quest...
Check out my YouTube Channel!

User avatar
Hazelnut
Posts: 596
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build #105 - Guild membership lost

Post by Hazelnut » Sun Apr 29, 2018 5:56 pm

Thanks for the investigations and reports Midnightprince - very helpful.

To be completely accurate, the problem was loading saves outside. I made a stupid mistake and didn't spot it because I've not been working on DFU since then.

Anyway have submitted a fix PR now so will be fixed in the next build. I apologise to anyone who lost their memberships to this bug.

User avatar
Interkarma
Posts: 3036
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #105 - Guild membership lost

Post by Interkarma » Sun Apr 29, 2018 6:26 pm

Thanks for fixing Hazelnut! I'll get up some new builds soon.

It's seriously no problem either. I think everyone understands the purpose of these test builds is to find bugs so we can fix them. :)

User avatar
Midknightprince
Posts: 664
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Build #105 - Guild membership lost

Post by Midknightprince » Mon Apr 30, 2018 12:40 am

I saw the fix on Git, that was fast guys.
Ill test it unless a new lb is coming, im lazy today :D
Check out my YouTube Channel!

User avatar
Midknightprince
Posts: 664
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Build #105 - Guild membership lost

Post by Midknightprince » Mon Apr 30, 2018 9:46 am

Yep, seems to be fixed, I'll watch it...
Check out my YouTube Channel!

Post Reply