Theives guild on city map not showing up X64 #28 [RESOLVED]

Report specific bugs in Daggerfall Unity. Please read guidelines before posting.
User avatar
Nystul
Posts: 1121
Joined: Mon Mar 23, 2015 8:31 am

Re: Theives guild on city map not showing up X64 #28

Post by Nystul » Thu May 10, 2018 3:14 pm

one way to go would be to filter indeed by name "Residence" but get this string from recently introduced ConversationText.txt file. Translators would then have to be cautious to translate this correctly but it would work.
Interkarma, where does your building name creation / discovery mechanism get the string "Residence" from? maybe best thing would to make a common mechanism that all systems use for deriving string "Residence" and automap could then filter it. Of course this mechanism must support translations

User avatar
Nystul
Posts: 1121
Joined: Mon Mar 23, 2015 8:31 am

Re: Theives guild on city map not showing up X64 #28

Post by Nystul » Fri May 11, 2018 12:42 pm

found an easy way to filter nameplates for tg, dbh guild buildings. pull request issued (along with a fix so that guild halls get revealed also on guild join not only on locationrect change
everything behaves now like this:
  • normal buildings as always
  • tg, dbh not revealed when not member (also when info clicking they will return "Residence")
  • tg, dbh revealed as soon as pc is member (then the will return "The Thieves Guild" resp. "The Dark Brotherhood" as expected when info clicking on them)
  • residences not showing up on map
  • named residences during quests showing up on map if pc learned about them and got them marked on the map (after quest they go back to "Residence" and are automatically hidden again)
    If player info-clicks on the correct house it currently returns "Residence", it will not show up as named residence on the map until player got building marked on map by npc - maybe we should change the info-clicking behaviour when clicking the correct house so that it returns the named residence and marks the building on the map - I am torn on this. It is not realistic to click a house unknown to the player and get the special name - on the other hand compass direction hints by npc are not of much use if you don't have a mechanism to pin down a searched house - what do you think?
most of this stuff is working because Interkarma and Hazelnut did a great job - just had to fix some things cause of the new Residence-handling arising from recent changes

User avatar
Midknightprince
Posts: 672
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Theives guild on city map not showing up X64 #28

Post by Midknightprince » Fri May 11, 2018 6:28 pm

Nystul wrote:
Fri May 11, 2018 12:42 pm
found an easy way to filter nameplates for tg, dbh guild buildings. pull request issued (along with a fix so that guild halls get revealed also on guild join not only on locationrect change
everything behaves now like this:
  • normal buildings as always
  • tg, dbh not revealed when not member (also when info clicking they will return "Residence")
  • tg, dbh revealed as soon as pc is member (then the will return "The Thieves Guild" resp. "The Dark Brotherhood" as expected when info clicking on them)
  • residences not showing up on map
  • named residences during quests showing up on map if pc learned about them and got them marked on the map (after quest they go back to "Residence" and are automatically hidden again)
    If player info-clicks on the correct house it currently returns "Residence", it will not show up as named residence on the map until player got building marked on map by npc - maybe we should change the info-clicking behaviour when clicking the correct house so that it returns the named residence and marks the building on the map - I am torn on this. It is not realistic to click a house unknown to the player and get the special name - on the other hand compass direction hints by npc are not of much use if you don't have a mechanism to pin down a searched house - what do you think?
most of this stuff is working because Interkarma and Hazelnut did a great job - just had to fix some things cause of the new Residence-handling arising from recent changes
Wow, that is ALOT of stuff dude..
Sorry, had to say it :D
I will check this out later tonight
Check out my YouTube Channel!

User avatar
Nystul
Posts: 1121
Joined: Mon Mar 23, 2015 8:31 am

Re: Theives guild on city map not showing up X64 #28

Post by Nystul » Fri May 11, 2018 10:44 pm

just keep in mind that those things will be available with next build though - so you might have to wait a bit longer

User avatar
Interkarma
Posts: 3174
Joined: Sun Mar 22, 2015 1:51 am

Re: Theives guild on city map not showing up X64 #28

Post by Interkarma » Fri May 11, 2018 10:49 pm

Just on that, I've merged everything and will put up some new builds this weekend. I just want to knock out a few more effects first.

User avatar
Nystul
Posts: 1121
Joined: Mon Mar 23, 2015 8:31 am

Re: Theives guild on city map not showing up X64 #28

Post by Nystul » Fri May 11, 2018 11:02 pm

Interkarma, how do you think we should handle info-clicking quest named residences? like classic that they get revealed on info-clicking or more realistic that player needs to get them marked on map and info-clicking won't show their name? Currently the mechanism for info-clicking returns "Residence"...

User avatar
Midknightprince
Posts: 672
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Theives guild on city map not showing up X64 #28

Post by Midknightprince » Sat May 12, 2018 2:00 am

Ok, this one is fixed, just tested in lastest Github version.
Thanks guys :D
Check out my YouTube Channel!

User avatar
Interkarma
Posts: 3174
Joined: Sun Mar 22, 2015 1:51 am

Re: Theives guild on city map not showing up X64 #28

Post by Interkarma » Sat May 12, 2018 3:17 am

Thanks for the status updates! :)

User avatar
Nystul
Posts: 1121
Joined: Mon Mar 23, 2015 8:31 am

Re: Theives guild on city map not showing up X64 #28 [RESOLVED]

Post by Nystul » Sat May 12, 2018 9:51 am

my question from above is still open. would like to hear you opinion on it:
Nystul wrote:
Fri May 11, 2018 11:02 pm
Interkarma, how do you think we should handle info-clicking quest named residences? like classic that they get revealed on info-clicking or more realistic that player needs to get them marked on map and info-clicking won't show their name? Currently the mechanism for info-clicking returns "Residence"...

User avatar
Interkarma
Posts: 3174
Joined: Sun Mar 22, 2015 1:51 am

Re: Theives guild on city map not showing up X64 #28 [RESOLVED]

Post by Interkarma » Sat May 12, 2018 9:57 am

You should be able to draw from SiteLink data in quest machine and link building IDs to get the temp name. Will be able to help with this later if needed. :)

Post Reply