Page 1 of 2
Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time [RESOLVED]
Posted: Mon Jun 25, 2018 12:03 am
by Interkarma
This is a very minor issue. Sometimes when initiating dialog with an NPC, they will start on the "where is" option and dump some dialog about the top option several times in a row.
I didn't click on anything other than NPC, the talk window opened in the following way. The game otherwise keeps running normally.
There are no exceptions in the output log. A save game is attached that will hopefully help reproduce. I just need to keep opening dialog several times with different NPCs before it happens.
- chatty-guy.jpg (113.09 KiB) Viewed 6311 times
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Mon Jun 25, 2018 12:09 am
by Interkarma
Update: I'm now unable to reproduce after closing and reopening game. I'll let you know if I can get any more detail on this one later. It's otherwise a very minor thing, just adding bug report for completeness.
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Mon Jun 25, 2018 9:30 am
by Nystul
I think there is still a issue with clicks resulting in more than one click event. You remember the window close/reopen issue. I know you implemented a fix. But I still get this issue every now and then.
It might be related to this issue if it selects entries in the list. But it also could be something else.
Regarding the doubled click registration: I used the function Input.ResetInpuAxis with success earlier which also resets mouse clicks
I don't understand why it starts in the where is section though
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Mon Dec 03, 2018 10:08 pm
by pango
This sometimes happens with inventory window when clicking on corpses too.
From time to time I loot corpses that have one of my objects (usually my lamp... or maybe that's when I notice it, because I'm suddenly out of light!)
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Tue Dec 04, 2018 12:00 am
by Interkarma
Yep, likely another case of input fall-through from world to UI.
I did not create a good design for cleanly separating input handling between world and UI. What I thought was adequate at the time turned out to have some failings. Will fix this over time. It's also one of those lessons learned to take into my next project.
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Tue Dec 04, 2018 7:07 am
by pango
I haven't checked the code so it may be easier said than done but, could interface elements be triggered on "mouse up" events rather than "mouse down" events?
From the little GUI work I did (in Windows 3.x days
) that was the behavior of buttons, and barely anybody notices...
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Wed Dec 05, 2018 12:14 am
by pango
Code: Select all
diff --git a/Assets/Scripts/Game/PlayerActivate.cs b/Assets/Scripts/Game/PlayerActivate.cs
index 20679db2..ee61a512 100644
--- a/Assets/Scripts/Game/PlayerActivate.cs
+++ b/Assets/Scripts/Game/PlayerActivate.cs
@@ -128,7 +128,7 @@ namespace DaggerfallWorkshop.Game
}
// Fire ray into scene
- if (InputManager.Instance.ActionStarted(InputManager.Actions.ActivateCenterObject))
+ if (InputManager.Instance.ActionComplete(InputManager.Actions.ActivateCenterObject))
{
// TODO: Clean all this up
or something like that. It doesn't closely emulate classic, but seems very effective
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Wed Dec 05, 2018 1:49 am
by Interkarma
Thank you, but I'd rather resolve this a different way than invert the input sampling for button presses. I'll loop back to this bug report later now it's been identified as input fall-through. Cheers.
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Fri Jul 26, 2019 2:13 pm
by mikeprichard
Although the same random wandering NPC ("Rodyctor Ashham") as appears in the top screenshot didn't show up for me when I loaded the attached save, I can't reproduce this with any other NPC in Win 7 as of latest build 0.8.6. Has the underlying input fall-through issue been resolved?
Re: Live Code as of 25-June-18 - Talk Window > Where Is Directions Repeating Several Time
Posted: Fri Jul 26, 2019 2:29 pm
by Jay_H
This still happens to me (Linux 64bit 0.8.6).