Build #122 - Oops! Tell Mark now! [CLOSED]

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Build #122 - Oops! Tell Mark now! [CLOSED]

Post by Interkarma »

Reported on Reddit. The guard NPC next to King Gothryd doesn't get a portrait. I know this is an easy fix thanks to Nystul, just posting report here so it can be worked on later.
oops1.jpg
oops1.jpg (70.23 KiB) Viewed 2912 times
oops-2.jpg
oops-2.jpg (96.55 KiB) Viewed 2912 times

User avatar
King of Worms
Posts: 4752
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Build #122 - Oops! Tell Mark now!

Post by King of Worms »

Can this thread be used for reporting this kind of bugs? There are many. I dont really know how to fix this thing, eventho it was explained to me before.

Bug report could be written in this manner:

Archive name(-s, in case of multiple archives)
-------------------
Face number


Pls let me know if this would be of any help, or if I should change the reporting style.
Last edited by King of Worms on Fri Jul 20, 2018 10:11 am, edited 1 time in total.

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Build #122 - Oops! Tell Mark now!

Post by Nystul »

this would be of great help, one thing that would be useful is to also add the location of the npc who has the wrong portrait (one example for every unique texture record/archive combination). This way it is easy to test for fixing purposes.

User avatar
King of Worms
Posts: 4752
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Build #122 - Oops! Tell Mark now!

Post by King of Worms »

Got it! I will start with the main 3 castles, as that will cover huge part of bugs. This post includes all the reports from above including the Interkarmas one. Lets do it!

CASTLE DAGGERFALL

- Throne room:

182_6-0 (Green joker)
334_3-0
----------
TFAC00I0.RCI_487-0


182_5-0 (Yellow joker)
334_6-0
346_3-0
----------
TFAC00I0.RCI_486-0


182_45-0 (Lady)
334_10-0
-----------
TFAC00I0.RCI_493-0


182_51-0 (Animated guitar player sets)
334_11-0
-----------
TFAC00I0.RCI_496-0


183_3-0 (Guard)
334_16-0
346_20-0
357_13-0
-----------
TFAC00I0.RCI_404-0


- South locked room:


183_16-0 (Noble)
334_20-0
-----------
FACES.CIF_51-0


182_24-0 (Reading book)
334_7-0
--------------
TFAC00I0.RCI_443-0


182_42-0 (Child)
334_9-0
----------
TFAC00I0.RCI_490-0


182_59-0 (Animated smith - same room behind the West doors)
-----------
TFAC00I0.RCI_364-0
Last edited by King of Worms on Fri Jul 20, 2018 11:58 am, edited 6 times in total.

User avatar
King of Worms
Posts: 4752
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Build #122 - Oops! Tell Mark now!

Post by King of Worms »

CASTLE SENTINEL

- Main entrance hall:

182_36-0 (Lute guy in turban)
357_5-0
---------
TFAC00I0.RCI_454-0


182_35-0 (Pirate)
357_4-0
---------
TFAC00I0.RCI_453-0


182_9-0 (Lady)
357_2-0
---------
TFAC00I0.RCI_433-0


- Garden, north room closer to entrance

184_33-0 (Lady)
-----------
TFAC00I0.RCI_362-0


- Throne room

182_49-0 (Animated joker sets)
357_8-0
---------
TFAC00I0.RCI_494-0


182_57-0 (Left bodyguard)
357_10-0
-----------
TFAC00I0.RCI_468-0


182_58-0 (Right bodyguard)
357_11-0
-----------
TFAC00I0.RCI_501-0


- Small room North by the throne


183_7-0 (Guy in turban)
357_14-0
-----------
TFAC00I0.RCI_436-0 (just the most similar portrait Ive found)
Last edited by King of Worms on Fri Jul 20, 2018 11:59 am, edited 2 times in total.

User avatar
King of Worms
Posts: 4752
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Build #122 - Oops! Tell Mark now!

Post by King of Worms »

CASTLE WAYREST

- Throne room:

183_2-0 (Guard south at the entrance)
334_15-0
346_19-0
357_12-0
-----------
TFAC00I0.RCI_403-0


182_40-0
346_14-0
-----------
TFAC00I0.RCI_477-0


346_8-0
------------------------
TFAC00I0.RCI_499-0
(well, here I used the alternative sprite in a hood with a red eyes, this face will go well with it, and I will add the red eyes to portrait as well - still - for sure this face is better than a generic redguard used IMO, hooded or not)

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Build #122 - Oops! Tell Mark now!

Post by Nystul »

Thanks, will take a look soon

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #122 - Oops! Tell Mark now!

Post by Interkarma »

Stickying this one as it's a combined thread for this bug. If anyone else sees "Oops! Tell Mark now!" please provide some detail about the NPC you encounter this on.

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Build #122 - Oops! Tell Mark now!

Post by Nystul »

I am working on this right now. Thanks for the lists king of worms! they are of great value.
funny how broken even vanilla df is with portraits in the throne rooms. ;)

update: I created a new pull request which should fix the portraits in daggerfall, wayrest and sentinel castle. btw. did someone test the npcs in orsinium and in the scourg barrow? what about witch covens?

User avatar
King of Worms
Posts: 4752
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Build #122 - Oops! Tell Mark now!

Post by King of Worms »

Hi, Im glad it was helpful! Yes, it was just a huge mess :) in orsinium, that ork has a correct portrait. Scourg barrow - not tested yet, as im not sure how to open that gate leading to KoWs lair :/ i can retry that and check it tomorrow! And the covens. Thanks for this bugfixing Nystul!

Locked