Dev build/Linux: buffs don't blink when they're about to expire [RESOLVED]

Locked
User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Dev build/Linux: buffs don't blink when they're about to expire [RESOLVED]

Post by pango »

That's most likely a known bug because it seems that the code to make buff icons blink for the last 2 rounds seems to be there, but it does not seem to work (and it's pretty useful for levitation and other spells).
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7245
Joined: Sun Mar 22, 2015 1:51 am

Re: Dev build/Linux: buffs don't blink when they're about to expire

Post by Interkarma »

This sounds like a regression. I'll take a look, cheers.

User avatar
Interkarma
Posts: 7245
Joined: Sun Mar 22, 2015 1:51 am

Re: Dev build/Linux: buffs don't blink when they're about to expire

Post by Interkarma »

I've tested this with current code and buffs are still blinking as normal when <2 magic rounds are remaining.

It shouldn't be a platform-specific thing as the it's just a basic panel enable/disable toggle. Could you perhaps hit me with a save game to reproduce? I'll look a bit closer.

User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: buffs don't blink when they're about to expire

Post by pango »

Oh...
With another character it doesn't happen.

That character has magic greaves and magic left pauldron with Intelligence and Fortitude when held.
I have them for a long time and their buff icons have disappered (that's probably a first issue).

And they may have messed up blinking, but I'm not sure how, because if I remove those items and wait for their effects to fade, levitation spell still would not blink before expiring...
Attachments
SAVE62.zip
Flying
(217.91 KiB) Downloaded 68 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7245
Joined: Sun Mar 22, 2015 1:51 am

Re: Dev build/Linux: buffs don't blink when they're about to expire

Post by Interkarma »

Item buffs icons are definitely buggy, they shouldn't disappear. I just haven't had time to fix that one yet. The main thing is that spell buffs blink and expire normally.

I'll leave this one here to remind me to fix item buffs dropping out. The effect from the item doesn't expire, just the HUD icons are buggy. Magic items are still under development right now while spells are the main focus.

User avatar
Interkarma
Posts: 7245
Joined: Sun Mar 22, 2015 1:51 am

Re: Dev build/Linux: buffs don't blink when they're about to expire

Post by Interkarma »

I've fixed both this bug and the problem where spell icons by equipped items disappear prematurely.

Locked