Page 1 of 2

Build #135: Questgiver name doesn't match log [RESOLVED]

Posted: Sat Oct 13, 2018 2:34 pm
by BansheeXYZ
SAVE4.zip
(240.47 KiB) Downloaded 89 times
This merchant in gem store's name is "Fheldka". In the quest log and in conversation with henchman (go sleep at inn for 8 hours to fight him), she is referred to as "Fheldon". Possibly a male/female name check issue?

Note that I started this quest in build #133.

Re: Build #135: Questgiver name doesn't match log

Posted: Sat Oct 13, 2018 2:43 pm
by Interkarma
Thanks for report. I have this in my internal bug tracker, but will use this thread to remind me to fix later. Cheers. :)

Re: Build #135: Questgiver name doesn't match log

Posted: Wed Oct 24, 2018 1:11 pm
by R.D.
Note that I started this quest in build #133.
Name generation was recently changed to be closer to classic. If the name isn't saved as a string by the quest, but rather gets re-generated through the name creation function by a seed value or something, this would explain it, and I'd say this can be closed as it's just a temporary issue that won't happen for any new quests.

Re: Build #135: Questgiver name doesn't match log

Posted: Wed Oct 24, 2018 1:14 pm
by R.D.
I'm not sure about the timing of the builds and how they match up to GitHub commits. So the quest was started in Build #133, and the report comes for Build #135. I don't know when those came out, but the commit that changed name generation was on Sept. 30 and would have been in the next live build released after that.

Re: Build #135: Questgiver name doesn't match log

Posted: Thu Oct 25, 2018 10:35 am
by BansheeXYZ
This is not fixed in #135 or 137. If you get a quest from a woman, the female name is logged as the male version. I just got a quest from Caarci, and it was logged as "Caarcin" and I must do stuff for "him". If it's an escort quest, and the escort is a woman, a man's face will appear in your status space.

Re: Build #135: Questgiver name doesn't match log

Posted: Thu Oct 25, 2018 11:55 am
by Interkarma
Allofich, I believe this one is just related to gender of sprite not being injected to virtual questor at compile time. It's something I've been meaning to look at for a while, and have some ideas for approach.

Re: Build #135: Questgiver name doesn't match log

Posted: Thu Oct 25, 2018 1:24 pm
by R.D.
Ah, okay, so it's not the issue I suspected then.

Re: Build #135: Questgiver name doesn't match log

Posted: Thu Oct 25, 2018 3:53 pm
by BansheeXYZ
FYI, I just checked classic and it has its own issues with this stuff. For one, any time you ask for work, the person will give a name, and the following pronoun will always be he/him even if the name is female. i.e. look at this screenshot.

The other problem with classic is that you can find this person and... they don't offer the job, and then if you ask them for work, they say stuff about themselves and refer to themselves as a man. Weird.

Image

Re: Build #135: Questgiver name doesn't match log

Posted: Thu Oct 25, 2018 4:53 pm
by Hazelnut
Is this just because classic quest scripts don't both defining the gender of person resources properly?

Re: Build #135: Questgiver name doesn't match log

Posted: Thu Oct 25, 2018 8:42 pm
by Interkarma
Yep, there's just no system for keeping gender consistent between world and quests. A quest Person is technically a completely different virtual NPC to the one in the game world.

This gave me some grief early on when developing quest system until I realised it's a problem with classic design and just let it go for the time being. I have some ideas how to improve this, but won't give this priority for a while.