Build #138: Delivered letter doesn't display first use [RESOLVED]

Locked
BansheeXYZ
Posts: 555
Joined: Fri Oct 23, 2015 8:19 pm

Build #138: Delivered letter doesn't display first use [RESOLVED]

Post by BansheeXYZ »

I don't know if it's all letters or just this one from the Thieves Guild. But the first time you use it, it doesn't display. Subsequent uses, it does. See attachment.
SAVE7.zip
(137.69 KiB) Downloaded 102 times

User avatar
Jay_H
Posts: 4061
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: Build #138: Delivered letter doesn't display first use

Post by Jay_H »

I've had this bug for awhile now but have not reported it. Something to do with the quest engine, I would venture.

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build #138: Delivered letter doesn't display first use

Post by Hazelnut »

It's due to this code added by Interkarma, around line 1500 of DaggerfallInventoryWindow

Code: Select all

                // If item not already used, and is being watched, then pop back to HUD so quest system has first shot at it
                // On second pass the normal message popup will display instead
                if (!questItem.UseClicked && questItem.ActionWatching)
                {
                    questItem.UseClicked = true;
                    DaggerfallUI.Instance.PopToHUD();
                    return;
                }

It's intentional, but is not correct in this case. Will leave for Interkarma when he has time. Not a big problem but thanks for raising it.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Midknightprince
Posts: 1324
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Build #138: Delivered letter doesn't display first use

Post by Midknightprince »

I was wondering about this one, good show mates !
Check out my YouTube Channel!

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #138: Delivered letter doesn't display first use

Post by Interkarma »

I'm aware of this one. As Hazelnut points out, the quest system eats the initial click before the inventory system has a chance to act on it.

I'll look at redesigning this one when I can.

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #138: Delivered letter doesn't display first use

Post by Interkarma »

Resolved with a small redesign for parchment handling.

https://github.com/Interkarma/daggerfal ... 7901488e23

Locked