Build #139 - Casting spells via spellbook in middle of casting animation breaks casting/attacking [RESOLVED/CLOSED]

[BlueBolt]

So I found out casting certain spells like Waterbreathing via the spellbook then immediately opening the spellbook to cast again in the middle of the casting animation can break your actions and you can't attack/cast spells anymore. Unequipping and re-equiping or switching weapon hands doesn't fix the issue, nor does reloading the save. Your actions break again as soon as you try casting another spell upon reloading a save. Relaunching the game fixes the issue, however.

[Hazelnut]

Sounds very similar to the bow breaking during animation, certainly causing the same symptoms. In that case the animations run concurrently and when the bow broke, the array of frames is changed as the bow was auto-unequipped. Threw an exception if the coroutine was in the middle of accessing the frame array. All I did to fix it was catch and swallow the exception (don't tell anyone at work ) instead of implementing proper thread safe code. That would be complete overkill since the animation should just stop anyway.

That should help IK to fix this when he gets to it. (I hope)

[Interkarma]

I've not able to reproduce this one yet. There is already handling in place to block new casting while a cast is in progress, and recasting spells even accounts for animation playing. This should all be fairly robust, so it sounds like an edge case of some kind.

I can take a punt at the cause and shore up the process even further. I've pushed some new code now to prevent player from opening spellbook while cast animation is playing or from setting a new ready spell while a cast is in progress.

Please Let me know if you can reproduce after next round of builds.

[pango]

As indicated in the original report, it seems to only happen with specific spells, so can it be explained by an issue in casting animation?
On the other hand to "heavy handed" solution of preventing casting while the animation is playing may very well prevent lots of concurrency issues in spells...

[Interkarma]

As indicated in the original report, it seems to only happen with specific spells, so can it be explained by an issue in casting animation?

Yep, I got that. Still not able to reproduce.

On the other hand to "heavy handed" solution of preventing casting while the animation is playing may very well prevent lots of concurrency issues in spells...

This has been the design since casting was first built. My feeling is something else is happening or its an edge case of some kind. I've shored up the process even further now, and will see if problem persists. Otherwise, I'll close this one down the track.