0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Bug topics that have been resolved.
Locked
User avatar
Jay_H
Posts: 2519
Joined: Tue Aug 25, 2015 1:54 am

0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by Jay_H » Thu Feb 07, 2019 2:10 am

I'm testing this on #147 but I don't think that's a deciding factor. I can increase legal repute without an issue, but the command won't decrease it.

Code: Select all

_repfail_ task:
    remove foe _nme_
    legal repute -20
    end quest
leads to

Code: Select all

Action not found. Ignoring '    legal repute -20'
This is relevant for classic quest The Mixup, k0c00y06, which uses the same quest action.
Come join the Unofficial Daggerfall Unity Discord.
See the Daggerfall Unity Wiki on the UESP.
Progress on fixing classic quests here.

User avatar
Interkarma
Posts: 4713
Joined: Sun Mar 22, 2015 1:51 am

Re: 0.7.32: Action not found. Ignoring ' legal repute -20'

Post by Interkarma » Thu Feb 07, 2019 2:53 am

Thanks for letting me know, probably just a regex issue. Will fix up soon.

User avatar
Interkarma
Posts: 4713
Joined: Sun Mar 22, 2015 1:51 am

Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by Interkarma » Wed Mar 13, 2019 12:14 pm

I've updated "legal repute" regex to allow negative or positive integers.

User avatar
Jay_H
Posts: 2519
Joined: Tue Aug 25, 2015 1:54 am

Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by Jay_H » Wed Mar 13, 2019 1:34 pm

Cool, thanks Interkarma :)
Come join the Unofficial Daggerfall Unity Discord.
See the Daggerfall Unity Wiki on the UESP.
Progress on fixing classic quests here.

User avatar
TheLacus
Posts: 883
Joined: Wed Sep 14, 2016 6:22 pm
Contact:

Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by TheLacus » Sat Mar 16, 2019 10:12 pm

Can you confirm if the plus sign is to be considered optional for positive values? Tipton's docs and all classic quests use +/- when an integer is expected (see change repute with) so i followed this behaviour for the quest editor that i worked on. Now i opened it after a long time and saw a lot of errors in Jay_H quests due to this, so i will need to fix it for next update but i wanted to check with you if this is intentional.
If you are interested in creating mods for Daggerfall Unity you can find the documentation here.

User avatar
Jay_H
Posts: 2519
Joined: Tue Aug 25, 2015 1:54 am

Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by Jay_H » Sat Mar 16, 2019 10:41 pm

"legal repute" as a positive is only ever used once in Daggerfall. The other three uses are negative. All cases use signing.

http://github.com/Interkarma/daggerfall ... 000015.txt
http://github.com/Interkarma/daggerfall ... C00Y08.txt
http://github.com/Interkarma/daggerfall ... C00Y06.txt

Unless Interkarma knows something more, there's no evidence the command was meant to be used unsigned.
Come join the Unofficial Daggerfall Unity Discord.
See the Daggerfall Unity Wiki on the UESP.
Progress on fixing classic quests here.

User avatar
Interkarma
Posts: 4713
Joined: Sun Mar 22, 2015 1:51 am

Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by Interkarma » Sun Mar 17, 2019 1:29 am

Thank you Jay. I'll rework expression to support explicit positive and negative signing.

Edit: I've now tweaked this so all of the following are valid:

Code: Select all

legal repute 10
legal repute +10
legal repute -10

User avatar
Jay_H
Posts: 2519
Joined: Tue Aug 25, 2015 1:54 am

Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by Jay_H » Sun Mar 17, 2019 2:10 am

Ah, you didn't have to do that. I changed all my signage to be explicit anyway :lol: Thanks for the update.
Come join the Unofficial Daggerfall Unity Discord.
See the Daggerfall Unity Wiki on the UESP.
Progress on fixing classic quests here.

User avatar
TheLacus
Posts: 883
Joined: Wed Sep 14, 2016 6:22 pm
Contact:

Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]

Post by TheLacus » Sun Mar 17, 2019 10:27 pm

Interkarma wrote:
Sun Mar 17, 2019 1:29 am
I've now tweaked this so all of the following are valid
Thanks ;)
If you are interested in creating mods for Daggerfall Unity you can find the documentation here.

Locked