0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall [RESOLVED]

Locked
Calistex
Posts: 9
Joined: Wed Feb 13, 2019 1:47 pm

0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall [RESOLVED]

Post by Calistex »

If I ask the King at Castle Daggerfall about The Underking, the string shows "%rn[unhandled].

Screenshot:
Spoiler!
error_no_mod.png
error_no_mod.png (770.21 KiB) Viewed 2297 times

I can also provide a save right before the King, if it can be of any help.

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by pango »

Welcome to the forums Calistex!

I noticed the use of that macro in a quest (but did not make a separate report for it at the time)
viewtopic.php?f=24&t=1703
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Calistex
Posts: 9
Joined: Wed Feb 13, 2019 1:47 pm

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by Calistex »

Thank you, and sorry for useless post if the issue is already known :(

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by pango »

No biggie, at least the problem has its own entry now.
let not that refrain you from posting more bug reports ;) They're very useful
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

BansheeXYZ
Posts: 555
Joined: Fri Oct 23, 2015 8:19 pm

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by BansheeXYZ »

I did some research on this by looking at the output there in classic. It is indeed ruler name. Specifically, ruler name of the region you are in.

Regarding the use of the macro in the talk window as reported by OP: this is a negative response from nobles in general, not just King Gothryd. Therefore, it will look odd for this particular NPC because Gothryd is saying he's friends with himself.

I was not able to trigger this response in classic because there seem to be two kinds of negative responses: initial and follow-up. Follow-up responses don't show up in classic, you get one response and then endless "I don't know" stuff. I'm guessing it's a bug or something DFU corrected?

Anyway, the mage quest window was the only place I could see it in classic. Here are some results I got per region [%rt] [%rn]:

Sentinel: [Queen] [Queen Akorithi]
Northmoor: [Duke] [Dunane Gaerford]
Daggerfall: [King] [King Gothryd]
Wrothgarian M [Lord] [Tristore Wickhouse]
Daenia [Duchess] [Vannyssa Greenston]
Dwynnen [Baron] [Vyctyvyra Hawkford]
Koegria: [Lady] [Morgabyth Moorsley]
Menevia: [Countess] [Vyctausa Kingwing]
Anticlere: [Lady] [Lady Doryanna Flyte]

Note that according to UESP, smaller regions don't have named rulers, so I have no idea where the macro is grabbing these names. I do know that the name never changes, though. I went to other cities and the same name came up.

Also note that for large regions, the title is included in the name string for those NPCs, which results in title repetition here.

User avatar
Ferital
Posts: 282
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by Ferital »

For each reagion, the ruler is taken from FACTION.TXT data in two ways.

FIrst, DF will look for the first "individual" child faction of a region faction and if found, it will use it as the ruler. Therefore, only the following regions have a unique ruler:

Anticlere: Lady Doryanna Flyte
Daggerfall: King Gothryd
Isle of Balfiera: Medora
Lainlyn: Baron Shrike
Orsinium: Gortwog
Sentinel: Queen Akorithi
Wayrest: King Eadwyre

All other rulers bear random names and use a fixed title taken from the ruler field of a region faction data found in FACTION.TXT.

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by Hazelnut »

Thanks Ferital, I'll get that implemented soon. Unless you would like to do it yourself?
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Ferital
Posts: 282
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by Ferital »

If you already have a fix don't hesitate to push it as I probably won't be able to look at the code today :)

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by Hazelnut »

I tried the conversation from OP in classic and got this. Could the message above be a bug in DFU, or is this a difference in reputation of the PC?
king.PNG
king.PNG (97.22 KiB) Viewed 2031 times
Anyway this is added to my PR with general fixes.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Ferital
Posts: 282
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.36 (Win 10 x64) %rn[unhandled] when talking to the King of Daggerfall

Post by Ferital »

The difference with classic comes from reputation. There was also an issue in DFU making NPCs react much more negatively to player queries, Interkarma fixed it in a recent PR.

Locked