Dev build/Linux: quest involving books always pick the same one [RESOLVED]

Bug topics that have been resolved.
Locked
User avatar
pango
Posts: 1392
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Dev build/Linux: quest involving books always pick the same one [RESOLVED]

Post by pango » Sun Feb 24, 2019 6:03 pm

If you start a quest involving a random book (say, commoners quest A0C00Y12), the book picked is always "The First Scroll of Baan Dar".
Given it's book ID 0 in books.txt, I suspect quests to not fully initialize all the fields of the books they generate.
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 1392
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: quest involving books always pick the same one

Post by pango » Thu Apr 04, 2019 2:29 am

It seems that even random loot books are "The First Scroll of Baar"
https://www.youtube.com/watch?v=1jZB0arUJT4&t=745
or he's been very unlucky

(PS I think that was just luck)
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
jayhova
Posts: 581
Joined: Wed Jul 19, 2017 7:54 pm
Contact:

Re: Dev build/Linux: quest involving books always pick the same one

Post by jayhova » Thu Apr 04, 2019 4:21 pm

I have noticed this. It seems the system stops looking after i finds the first scroll. :lol:
Remember always 'What would Julian Do?'.
Windows 10 Pro 64 bit. DFU Ver. PreAlpha 0.8.6

User avatar
Midknightprince
Posts: 1096
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Dev build/Linux: quest involving books always pick the same one

Post by Midknightprince » Thu Apr 11, 2019 4:11 pm

I think this stuff ain't working right yet, I figure they know about it but they're doing other stuff, like maybe lycanthropy :D :D :D

Hey man it's possible....
Check out my YouTube Channel!

User avatar
Jay_H
Posts: 2695
Joined: Tue Aug 25, 2015 1:54 am

Re: Dev build/Linux: quest involving books always pick the same one

Post by Jay_H » Thu Apr 11, 2019 5:04 pm

pango wrote:
Thu Apr 04, 2019 2:29 am
It seems that even random loot books are "The First Scroll of Baar"
https://www.youtube.com/watch?v=1jZB0arUJT4&t=745
or he's been very unlucky

(PS I think that was just luck)
With the most recent builds I've found books as loot that aren't The First Scroll of Baan Dar. However, as a quest reward I believe it will always be that book.

User avatar
SlainByWoodborne
Posts: 67
Joined: Fri Apr 12, 2019 4:24 am

Re: Dev build/Linux: quest involving books always pick the same one

Post by SlainByWoodborne » Tue Apr 16, 2019 6:52 pm

I, too, have encountered an unlikely number of editions of "The First Scroll of Baan Dar" in quests, dungeons, containers, et cetera, in the Win_x64_0.7.91 version.

Wardrobe_w_2_BaanDar_SAVE38.7z
Load this save and look in the wardrobe directly ahead. Verify two books both named "The First Scroll of Baan Dar".

TheRiddle_pt2_BaanDar_SAVE39.7z
Load this save and look in the inventory. Verify "The First Scroll of Baan Dar" is a quest item for the second part of The Riddle.

Wardrobe_w_4_BaanDar_SAVE58.7z
Load this save and look in the wardrobe directly ahead. Verify four books all named "The First Scroll of Baan Dar".
Attachments
Wardrobe_w_4_BaanDar_SAVE58.7z
(230.85 KiB) Downloaded 8 times
TheRiddle_pt2_BaanDar_SAVE39.7z
(225.79 KiB) Downloaded 6 times
Wardrobe_w_2_BaanDar_SAVE38.7z
(223.04 KiB) Downloaded 7 times

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Dev build/Linux: quest involving books always pick the same one

Post by R.D. » Sat May 04, 2019 2:43 pm

Is every single book you encounter "The First Scroll of Baan Dar", or is it just common? (This is a question to anyone with this issue)

If you open the console and type "add book" what does it give you?

I'm getting random books with the console command and in treasure.

User avatar
pango
Posts: 1392
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: quest involving books always pick the same one

Post by pango » Sat May 04, 2019 2:50 pm

In my experience, books created for quests are always "The First Scroll of Baar".

Books in loot seem random, at least I've seen other books in loot.
"add book n" console works fine and generates random books (mmmh just created one "Book by %ba[nullMCP]", but that's another issue).
The problem must be that quest generator does not use the same code.
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Dev build/Linux: quest involving books always pick the same one

Post by R.D. » Sat May 04, 2019 3:33 pm

I just pushed a fix for quest reward books.

If random loot is okay now, as it seems to be, then I think we can close this after the fix is merged.

User avatar
SlainByWoodborne
Posts: 67
Joined: Fri Apr 12, 2019 4:24 am

Re: Dev build/Linux: quest involving books always pick the same one

Post by SlainByWoodborne » Sun May 05, 2019 3:13 am

If random loot includes containers in buildings in towns, I would say that may also need to be examined.

viewtopic.php?p=23392#p23392

Locked