0.7.65: wrong ruler in "Any news" [RESOLVED]

Post Reply
User avatar
Ferital
Posts: 47
Joined: Thu Apr 05, 2018 8:01 am

0.7.65: wrong ruler in "Any news" [RESOLVED]

Post by Ferital » Mon Mar 11, 2019 3:23 pm

When asking an NPC for any news, you can sometimes get information about a random new ruler of a random kindgom. But from what I remember in Classic, kindgoms with their ruler set in Factions.txt (Daggerfall, Sentinel, Wayrest, Anticlere, Lainlyn...) would use this one instead of generating a random name.

That's not the case in DFU:
Ruler news.png
Ruler news.png (337.02 KiB) Viewed 166 times

User avatar
Ferital
Posts: 47
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.65: wrong ruler in "Any news"

Post by Ferital » Wed Mar 13, 2019 7:23 pm

After investigating how classic works, I confirm there is an issue there. I'll submit a PR when I'll have time.

In classic, when you get information about the new ruler of any country, the game looks at first for a faction of type "facINDIVIDUAL" using the same region id as the country. And since Factions.txt contains many bugs, this can lead to odd news like that:
The Great Knight Lord of Ilessan Hills.PNG
The Great Knight Lord of Ilessan Hills.PNG (88.69 KiB) Viewed 123 times
:D

R.D.
Posts: 373
Joined: Fri Oct 07, 2016 10:41 am

Re: 0.7.65: wrong ruler in "Any news"

Post by R.D. » Thu Mar 14, 2019 10:55 am

I found what the problem is. A faction's "flags" value is assigned from the faction file with =, when it should be |=. Some factions (Sentinel, at least), have their flags value across multiple lines for some reason. This causes only the last value to be used, so the "ruler immune" flag that is supposed to protect story factions from getting the new ruler event gets overwritten. I'm sending a PR for it now.

User avatar
Ferital
Posts: 47
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.65: wrong ruler in "Any news"

Post by Ferital » Thu Mar 14, 2019 1:34 pm

Great! :)

R.D.
Posts: 373
Joined: Fri Oct 07, 2016 10:41 am

Re: 0.7.65: wrong ruler in "Any news"

Post by R.D. » Sun Mar 24, 2019 8:02 am

Resolved now.

Post Reply