0.7.91 Unhandled macro %kno in B0B00Y01 [RESOLVED]
- jayhova
- Posts: 924
- Joined: Wed Jul 19, 2017 7:54 pm
- Contact:
0.7.91 Unhandled macro %kno in B0B00Y01 [RESOLVED]
I'm on a quest to kill a guild member who has strayed from the path and it's dungeon crawl time. The variable does not resolve in my log correctly.
- Attachments
-
- SAVE29.zip
- (221.52 KiB) Downloaded 82 times
Remember always 'What would Julian Do?'.
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: 0.7.91 malformed quest variable
Can you please list the quest name name in bug report title? I'll take a look when I can and move back to bug reports once confirmed. Cheers.
- Jay_H
- Posts: 4072
- Joined: Tue Aug 25, 2015 1:54 am
- Contact:
Re: 0.7.91 malformed quest variable
The quest is B0B00Y01, The variable is %kno which returns [srcDataUnknown]. Classic would resolve this to the Knightly Order that gave you the quest.
This phrasing is also existent in B0B60Y12.txt, B0B50Y11.txt, B0B40Y09.txt, B0B70Y14.txt. B0B20Y07.txt, and B0B70Y16.txt.
This phrasing is also existent in B0B60Y12.txt, B0B50Y11.txt, B0B40Y09.txt, B0B70Y14.txt. B0B20Y07.txt, and B0B70Y16.txt.
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: 0.7.91 malformed quest variable %kno in B0B00Y01
Thanks for taking a look Jay, appreciate it.
- Jay_H
- Posts: 4072
- Joined: Tue Aug 25, 2015 1:54 am
- Contact:
Re: 0.7.91 malformed quest variable %kno in B0B00Y01
I corrected my post above; it's also used in other quests so I think the only good solution is to implement %kno.
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: 0.7.91 malformed quest variable %kno in B0B00Y01
Thanks Jay, yep implementing the macro is preferred.
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: 0.7.91 Unhandled macro %kno in B0B00Y01
The macro is implemented but isn't able to retrieve the data correctly. I'll take a look at some point.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: 0.7.91 Unhandled macro %kno in B0B00Y01
This should be fixed by the PR I've submitted.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
-
- Posts: 555
- Joined: Fri Oct 23, 2015 8:19 pm
Re: 0.7.91 Unhandled macro %kno in B0B00Y01
Good fix, however, I don't think removing "the" from the order name is better than correcting the quest files. If I were using %kno in my own quest file, I would not precede it with a "the" because it's formally always part of the guild name, then your method backfires because I'm not making the mistakes classic made. There's another reason, and that's to make sure "The" gets capitalized mid-sentence as it should be.
Take this part of the quest file, in the rumors section:
You don't play around with the Knights of the Dragon.
With the quest file corrected:
You don't play around with The Knights of the Dragon.
You can google these capitalization rules. But example sentences where this is invoked: "We were watching The Avengers at the theater." "We were watching The Abyss at the theater." If you don't capitalize the article when it's a part of the title, then the true title could be misconstrued by the reader.
Note: I'm not sure which guilds classic treats as having "The" as part of the actual guild name, so just keep all this mind.
Edit: thinking about this some more, removing "the" from the macro title does add some good flexibility. The sentence "Don't mess around with Knights of the Dragon members" sounds a lot better than "Don't mess around with The Knights of the Dragon members." Maybe your solution is better long-term.
Take this part of the quest file, in the rumors section:
With your method:You don't play around with the %kno.
You don't play around with the Knights of the Dragon.
With the quest file corrected:
You don't play around with The Knights of the Dragon.
You can google these capitalization rules. But example sentences where this is invoked: "We were watching The Avengers at the theater." "We were watching The Abyss at the theater." If you don't capitalize the article when it's a part of the title, then the true title could be misconstrued by the reader.
Note: I'm not sure which guilds classic treats as having "The" as part of the actual guild name, so just keep all this mind.
Edit: thinking about this some more, removing "the" from the macro title does add some good flexibility. The sentence "Don't mess around with Knights of the Dragon members" sounds a lot better than "Don't mess around with The Knights of the Dragon members." Maybe your solution is better long-term.
- Jay_H
- Posts: 4072
- Joined: Tue Aug 25, 2015 1:54 am
- Contact:
Re: 0.7.91 Unhandled macro %kno in B0B00Y01
Classic's treatment of it is pretty uneven.
B0B00Y01.txt
_qgiver_ can't just let =monster_ go after what %g did to the %kno.
B0B50Y11.txt
Poor _nobleman_ appealed to %kno to exorcise ___dungeon_, but they failed.
B0B60Y12.txt
%kno looked into _nobleman_'s story and, I guess, decided it was a hoax.
B0B40Y09.txt
The %kno saved %reg again. A %ra of their order killed the ___dungeon_ giant.
B0B70Y14.txt
No thanks to %kno, the end of Tamriel was narrowly averted.
B0B20Y07.txt
The %kno saved %reg from the __dungeon_ orcs. The hero was a %ra knight.
B0B70Y16.txt
%kno went stomping about in ___dungeon_ for no reason.
Since the danger of duplicate "the" exists, the best route is to omit it from the order name.
B0B00Y01.txt
_qgiver_ can't just let =monster_ go after what %g did to the %kno.
B0B50Y11.txt
Poor _nobleman_ appealed to %kno to exorcise ___dungeon_, but they failed.
B0B60Y12.txt
%kno looked into _nobleman_'s story and, I guess, decided it was a hoax.
B0B40Y09.txt
The %kno saved %reg again. A %ra of their order killed the ___dungeon_ giant.
B0B70Y14.txt
No thanks to %kno, the end of Tamriel was narrowly averted.
B0B20Y07.txt
The %kno saved %reg from the __dungeon_ orcs. The hero was a %ra knight.
B0B70Y16.txt
%kno went stomping about in ___dungeon_ for no reason.
Since the danger of duplicate "the" exists, the best route is to omit it from the order name.