[RESOLVED 0.10.19] 0.10.11 - Tiny female spellsword?

Locked
User avatar
Ralzar
Posts: 2211
Joined: Mon Oct 07, 2019 4:11 pm
Location: Norway

[RESOLVED 0.10.19] 0.10.11 - Tiny female spellsword?

Post by Ralzar »

Not sure if this is just me? The female spellsword model shrinks whenever she does the casting animation. It's been like this for at least 2 builds.

Image

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Tiny female spellsword?

Post by pango »

It's been like this for a much longer time...
I didn't care reporting it, as it lasts just one frame, but I definitely know about this issue
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
siteseer
Posts: 10
Joined: Thu Jul 25, 2019 12:23 am

Re: Tiny female spellsword?

Post by siteseer »

not just you. but seeing as it is not a game breaking bug we may have to suffer it for a while, unless the fix is an easy one.

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Tiny female spellsword?

Post by Interkarma »

I had a manual workaround for something like this way back in the early days (circa 2014/2015). I think I got it wrong though, as Allofich removed the code a couple of years later because it was actually making the Thief sprite orientation larger.

https://github.com/Interkarma/daggerfal ... -331660562

I think what happened is that I applied the workaround the wrong enemy type, and couldn't recall what I saw a couple years later when it came into question.

Adding back the following code removed from PR above, and also correcting enemy type and orientation, should take care it. I'll move this to bug reports so it can be followed up on.

Code: Select all

// Post-fix female thief scale for orentations 1 and 7
// The scale read from Daggerfall's files is too small
if ((MobileTypes)summary.Enemy.ID == MobileTypes.Thief &&
     summary.Enemy.Gender == MobileGender.Female &&
     (orientation == 1 || orientation == 7))
{
    size *= 1.35f;
}

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: 0.10.11 - Tiny female spellsword?

Post by pango »

Issue looks similar, but not identical. It's the "spell casting" records (20 to 24) that don't have the same size as others this time:
nightblade.jpg
nightblade.jpg (111.89 KiB) Viewed 1351 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: 0.10.11 - Tiny female spellsword?

Post by pango »

I submitted a PR
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: 0.10.11 - Tiny female spellsword?

Post by pango »

This should be fixed by 0.10.19 now
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Locked