[RESOLVED 0.10.19] 0.10.17 - Should feet defence be -3 without shoes?

[Seferoth]

Thank you, was really nice to hear that.

Edit: Some good news, i found an absolutely fantastic combination of clothes that uses SANDALS! I can actually use them. Will post the pick to Daggerfashion topic when i have everything ready.

[BadLuckBurt]

There's an elusive bug that still gets the feet armor value out of sync. I've been unable to find it, so really need a save along with a set of instructions that reproduce this behaviour reliably.

I've done a quick test with my character and this is the behaviour:

1. Equip shoes on character and defense is raised to 3. (This also appears to happen in classic)
2. Save game with shoes on and reload, feet defense is 0
3. Unequip shoes and defense drops to -3 (Equipping shoes again brings it back to 0)
4. Saving game bare footed with defense at -3 and reloading resets defense to 0
5. Equipping shoes sets defense to 3 - bringing it back to step 1

I'll check in the saving / loading code why it isn't being restored properly but I think that's where the issue lies, the shoes seem to be ignored upon load but not during equipping / unequipping.

I don't know why they are treated as leather boots but that may have to do with the way they're defined in classic's data. Will report back when I figure it out.

[BadLuckBurt]

Thank you, was really nice to hear that.

Edit: Some good news, i found an absolutely fantastic combination of clothes that uses SANDALS! I can actually use them. Will post the pick to Daggerfashion topic when i have everything ready.

You're welcome, some things just need to be said

Check my post above this one, I think I know where the problem lies since I can reproduce it reliably but I'll investigate a little further.

[Seferoth]

There's an elusive bug that still gets the feet armor value out of sync. I've been unable to find it, so really need a save along with a set of instructions that reproduce this behaviour reliably.

I've done a quick test with my character and this is the behaviour:

1. Equip shoes on character and defense is raised to 3. (This also appears to happen in classic)
2. Save game with shoes on and reload, feet defense is 0
3. Unequip shoes and defense drops to -3 (Equipping shoes again brings it back to 0)
4. Saving game bare footed with defense at -3 and reloading resets defense to 0
5. Equipping shoes sets defense to 3 - bringing it back to step 1

I'll check in the saving / loading code why it isn't being restored properly but I think that's where the issue lies, the shoes seem to be ignored upon load but not during equipping / unequipping.

I don't know why they are treated as leather boots but that may have to do with the way they're defined in classic's data. Will report back when I figure it out.

Wait...all i had to do to fix this(momentarily) was to save and reload? I swear i tried this before! I tried this and it worked! I am shocked how UTTERLY MORON I AM! I have been whining and moaning here for two days and that's all i had to do? SAVE AND RELOAD!? I feel like laughing and crying at the same time. Thank you for bringing this to my attention and now excuse me while i go and jump off my balcony.

Edit: *Comes back from the ledge* Wait, so is the +3 a bug or not? I mean it does not really make sense why shoes would be the only clothes to raise defense.

[Hazelnut]

The code has all shoes except for sandals offer the basic +3 protection of leather boots - this is to match classic DF as far as I know, but I have not researched the original behaviour myself. The bug here seems to be a difference in game equipping vs. re-loading a save. That is the missing link I believe, so I should be able to track that down and fix it. Thank you guys.

Yep, found it. The initialisation of armor values ignores the shoes and that causes the bug as it only registers the values from actual armor pieces. I will take a look at fixing it when I get a chance.

[Seferoth]

The code has all shoes except for sandals offer the basic +3 protection of leather boots - this is to match classic DF as far as I know, but I have not researched the original behaviour myself. The bug here seems to be a difference in game equipping vs. re-loading a save. That is the missing link I believe, so I should be able to track that down and fix it. Thank you guys.

Yep, found it. The initialisation of armor values ignores the shoes and that causes the bug as it only registers the values from actual armor pieces. I will take a look at fixing it when I get a chance.

Excellent news. Thank you.

[BadLuckBurt]

Awesome, mission accomplished

[Seferoth]

Awesome, mission accomplished

https://www.youtube.com/watch?v=-YCN-a0NsNk

[Lokkrin Zhataros]

Great to hear that another bug is being fixed! When thinking back on this I do seem to remember this shoe stats bug being in classic Daggerfall, you found this as well Seferoth. I probably just ignored it thinking "it's buggy Daggerfall, can't do anything about it" or similar and never proceeded to find it in DFU.

[Seferoth]

It's always nice to see old and elusive bugs squashed. This one did drive me insane though.