[0.10.21] Armor That Breaks While Equipped, Increased Armor Persists [RESOLVED 0.10.22]

Bug topics that have been resolved.
Locked
User avatar
Magicono43
Posts: 176
Joined: Tue Nov 06, 2018 7:06 am

[0.10.21] Armor That Breaks While Equipped, Increased Armor Persists [RESOLVED 0.10.22]

Post by Magicono43 » Thu Mar 12, 2020 2:46 am

**Describe the bug**
If armor you have equipped breaks due to condition value going to 0, the item will be unequipped, but the armor that piece provided will persist on your character. You can even wear another piece where the old piece was and increase armor further. This does not persist through save-games, so if you save and reload with this bugged armor value, it will be removed when you load the save.

**To Reproduce**
Steps to reproduce the behavior:
-This was discovered while playing around with a mod that alters how much condition damage items take from being hit, so this is somewhat difficult to reproduce in Vanilla.

-Best bet is to figure out a quick way to reduce an equipped armor item's condition damage to 0, and you will see the broken item is removed, but the armor that it provided is still around and can be stacked with other items. (I can upload a .dfmod that helps with this if somebody needs that to reproduce.)

**Expected behavior**
Broken item should be unequipped upon breaking, and the armor it provided should go back down to 0/naked protection again.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: Windows
- Version: alpha 0.10.21

**Additional context**
Just a hunch here, but this may have similar origin to this other bug as well. viewtopic.php?f=24&t=3491

User avatar
Hazelnut
Posts: 2140
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: [0.10.21] Armor That Breaks While Equipped, Increased Armor Persists

Post by Hazelnut » Thu Mar 12, 2020 9:14 am

Thanks this and the other bug should be fixed by PR#1751
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Magicono43
Posts: 176
Joined: Tue Nov 06, 2018 7:06 am

Re: [0.10.21] Armor That Breaks While Equipped, Increased Armor Persists

Post by Magicono43 » Thu Mar 12, 2020 1:07 pm

Hazelnut wrote:
Thu Mar 12, 2020 9:14 am
Thanks this and the other bug should be fixed by PR#1751
Awesome, was worried it was going to be really hard to pin-point, but apparently not.

User avatar
Interkarma
Posts: 5198
Joined: Sun Mar 22, 2015 1:51 am

Re: [0.10.21] Armor That Breaks While Equipped, Increased Armor Persists

Post by Interkarma » Fri Mar 13, 2020 12:08 am

Thank you Hazelnut for looking into this and fixing so quickly. We're lucky to have you. :)

User avatar
pango
Posts: 2194
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [0.10.21] Armor That Breaks While Equipped, Increased Armor Persists

Post by pango » Sun Apr 05, 2020 3:46 pm

This should be fixed in 0.10.22
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Locked