[0.10.23] "Save and Close" Button on Mod Settings Screen Throwing Exception

Curated user bug reports with enough information to reproduce issue. Moderators will move topics here from Help & Support once a bug is confirmed and enough information has been provided.
Post Reply
User avatar
Magicono43
Posts: 271
Joined: Tue Nov 06, 2018 7:06 am

[0.10.23] "Save and Close" Button on Mod Settings Screen Throwing Exception

Post by Magicono43 » Sat May 09, 2020 11:40 pm

So on the mod settings screen, when you try and click the "Save and Close" button, the first time you click, a null object reference is being thrown, when you try and click after this "unresponsiveness" it works normally. Ralzar is likely correct that this is being thrown by what is supposed to pop up as the "Detecting Settings For Mods Not Installed" message box.

Here is the exception as shown by the Unity debug screen:

Code: Select all

NullReferenceException: Object reference not set to an instance of an object
ModLoaderInterfaceWindow.CheckDependencies () (at Assets/Game/Addons/ModSupport/ModLoaderInterfaceWindow.cs:468)
ModLoaderInterfaceWindow.MoveNextStage () (at Assets/Game/Addons/ModSupport/ModLoaderInterfaceWindow.cs:523)
ModLoaderInterfaceWindow.Update () (at Assets/Game/Addons/ModSupport/ModLoaderInterfaceWindow.cs:306)
DaggerfallWorkshop.Game.DaggerfallUI.Update () (at Assets/Scripts/Game/DaggerfallUI.cs:363)
Last edited by Magicono43 on Sun May 10, 2020 3:37 pm, edited 1 time in total.

User avatar
Ralzar
Posts: 1066
Joined: Mon Oct 07, 2019 4:11 pm
Location: Norway

Re: [0.10.23] "Save and Close" Button on Mod Settings Screen Throwing Exception

Post by Ralzar » Sun May 10, 2020 5:46 am

Yeah, I'm getting it too. In the Live Build it just seems like nothing happens the first time you click "Save and Close" and then it works the second time.

I think Hazelnut was experiencing the same thing.

Edit: Not sure, but it seems to only happen if you DON'T have any old settings. So as long as you have settings for mods you no longer have installed, the popup forks fine. But if you ever click "YES", you'll start experiencing the bug.
My released mods

"I feel like Ralzar specifically wrote those mods for me and then said "Use them". Just so he could watch me die more."
-FuzzyBeanPlays

User avatar
Hazelnut
Posts: 2189
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: [0.10.23] "Save and Close" Button on Mod Settings Screen Throwing Exception

Post by Hazelnut » Sun May 10, 2020 11:20 am

Yep, I noticed this yesterday myself. Going to move this to bug reports for TheLacus (I assume) to deal with.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
TheLacus
Posts: 1150
Joined: Wed Sep 14, 2016 6:22 pm
Contact:

Re: [0.10.23] "Save and Close" Button on Mod Settings Screen Throwing Exception

Post by TheLacus » Sun May 10, 2020 3:20 pm

Thank you for the report.
Mod System documentation - Learn how to create mods for Daggerfall Unity.
Modder Discussion - General help and discussion for the mod system.
Github Issues - Submit a bug report for the game, including the mod system.

User avatar
TheLacus
Posts: 1150
Joined: Wed Sep 14, 2016 6:22 pm
Contact:

Re: [0.10.23] "Save and Close" Button on Mod Settings Screen Throwing Exception

Post by TheLacus » Sun May 10, 2020 7:56 pm

Fixed. Sorry for this one, i missed a null check...
Mod System documentation - Learn how to create mods for Daggerfall Unity.
Modder Discussion - General help and discussion for the mod system.
Github Issues - Submit a bug report for the game, including the mod system.

User avatar
Magicono43
Posts: 271
Joined: Tue Nov 06, 2018 7:06 am

Re: [0.10.23] "Save and Close" Button on Mod Settings Screen Throwing Exception

Post by Magicono43 » Sun May 10, 2020 8:56 pm

TheLacus wrote:
Sun May 10, 2020 7:56 pm
Fixed. Sorry for this one, i missed a null check...
Cool, thanks Lacus.

Post Reply