Mummy Wrappings Quest Bug [RESOLVED 0.10.23]

Locked
kingink
Posts: 4
Joined: Mon Mar 02, 2020 4:23 pm

Mummy Wrappings Quest Bug [RESOLVED 0.10.23]

Post by kingink »

Using version: 10.20 Linux 64-bit

On completion of the mummy wrappings quest for the mages guild, the mummy wrappings quest item is not removed from inventory resulting in mummy wrappings permanently stuck in inventory.

(Err... Any console command to get rid of this thing?)

Save from before turning in quest included.
Attachments
save.7z
(335.76 KiB) Downloaded 98 times

User avatar
Interkarma
Posts: 7247
Joined: Sun Mar 22, 2015 1:51 am

Re: Mummy Wrappings Quest Bug

Post by Interkarma »

Thank you for save and version number! :)

This one is a known side-effect of how the quest is tombstoned (marked for deletion) for a time prior to actual expiration. When quests end, sometimes items need to stick around (e.g. Morgiah's wedding invitation) while other items need to disappear instantly (e.g. mummy wrappings). Unless the quest itself specifies, there's no universal way for the quest system to make that call.

The best way to fix this one would be to rewrite the success task in N0B00Y06 to remove the item at hand-in time:

Code: Select all

_reward_ task:
	toting _wrappings_ and _qgiver_ clicked 
	give pc _gold_ 
	take _wrappings_ from pc
	end quest 
On your side, the item will disappear within a few game days when the quest expires. Fast travelling some distance will tick this over faster.

User avatar
Jay_H
Posts: 4070
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: Mummy Wrappings Quest Bug

Post by Jay_H »

Interkarma wrote: Sun Mar 08, 2020 9:36 pmThe best way to fix this one would be to rewrite the success task in N0B00Y06 to remove the item at hand-in time
I've added it to my list.

User avatar
Interkarma
Posts: 7247
Joined: Sun Mar 22, 2015 1:51 am

Re: Mummy Wrappings Quest Bug

Post by Interkarma »

Thank you Jay! :)

User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Mummy Wrappings Quest Bug

Post by pango »

Just saw in DFQFIX list of fixes:

Code: Select all

S0000015
    The reward you get from Barenziah, Eadwyre or Helseth is not made permanent, which means it will vanish from your inventory as soon as the quest is over.
        This issue has been fixed.
So I guess the classic approach is to make quest items disappear when a quest is over, but can be overridden so that some items stay in inventory?
Also, checking the original quest with and without that patch could give some infos about how this is achieved...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7247
Joined: Sun Mar 22, 2015 1:51 am

Re: Mummy Wrappings Quest Bug

Post by Interkarma »

Non permanent items like this used to be cleared immediately on tombstone in DFU as well. Not sure exactly when that changed. I don't believe this issue existed back in 2017/18 when the quest system was in early progress, it's something that happened later.

I'll need to look at this soon in any case as I don't want this issue in Beta.

User avatar
Interkarma
Posts: 7247
Joined: Sun Mar 22, 2015 1:51 am

Re: Mummy Wrappings Quest Bug

Post by Interkarma »

Have investigated this and worked out why it's broken. Regression fixed in following commit.

https://github.com/Interkarma/daggerfal ... 77677f6c47

User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Mummy Wrappings Quest Bug

Post by pango »

Excellent!
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Locked