Page 15 of 18

Re: Custom quest support

Posted: Sat Jan 19, 2019 4:51 am
by Interkarma
This one seems like Hazelnut's wheelhouse. Just let me know if I'm needed at all. :)

Re: Custom quest support

Posted: Sat Jan 19, 2019 6:10 am
by Jay_H
It's happening with the Fighters Guild too now, with another character I started. Just did one quest (classic) and now it's the same error with them.

Re: Custom quest support

Posted: Wed Jan 23, 2019 10:05 pm
by Interkarma
The error itself is happening in the following line because oneTimeQuestsAccepted is null and the code is trying to access its members.

Code: Select all

if ((!quest.adult || DaggerfallUnity.Settings.PlayerNudity) && !(quest.oneTime && oneTimeQuestsAccepted.Contains(quest.name)))
It's just a simple logic error. The oneTimeQuestsAccepted list is only initialised when a one-time quest starts, but the same list is also being used to select a quest before it starts.

I moved the initialisation of oneTimeQuestsAccepted to right before its actually used, and added another safety null check when starting a one-time quest.

Hazelnut might want to refine this one further when he has time, but this will address this specific issue from next round of builds. I'll push out new builds a little sooner to fix this problem so people can play your quests again.

Re: Custom quest support

Posted: Wed Jan 23, 2019 10:15 pm
by Hazelnut
Oh, sorry Interkarma - been so focussed on my performance work/fun that I forgot all about this because it wasn't in bugs forum. :oops:

Re: Custom quest support

Posted: Wed Jan 23, 2019 10:21 pm
by Interkarma
S'right! Was a 5 minute fix and I'm happy to have been able to help. :)

Re: Custom quest support

Posted: Wed Jan 23, 2019 11:33 pm
by Jay_H
Yeeeahh! Thank you :D

EDIT: I see you already mentioned a hotfix build so I deleted my request :D Reading!

Re: Custom quest support

Posted: Thu Jan 24, 2019 5:57 am
by Jay_H
I altered the quest lists to remove the 1 values temporarily, so there's no need for an accelerated build. This fix is working fine from what I'm testing.

Re: Custom quest support

Posted: Thu Jan 24, 2019 6:03 am
by Interkarma
Yes, that should do it too, that null collection is only checked for one-time quests. :)

Will still get a hotfix up soon, just have a few PRs to finish testing.

Re: Custom quest support

Posted: Thu Jan 31, 2019 8:57 pm
by Hazelnut
Jay, could you recheck this with latest build please. I'll look into it if is still an issue.

Re: Custom quest support

Posted: Fri Feb 01, 2019 12:29 am
by Jay_H
Edited out