Enhanced Sky

A curated forum for compatible and maintained mods. Users are unable to create new topics in this forum but can reply to existing topics. Please message a moderator to have your mod moved into this forum area.
Post Reply
User avatar
Nystul
Posts: 1497
Joined: Mon Mar 23, 2015 8:31 am

Re: Enhanced Sky

Post by Nystul »

Interkarma wrote: Mon Nov 22, 2021 4:12 am I'm sorry there's no event for this, none of the fields exposed by SettingManager have events attached. It's just comparing an int though and shouldn't be very taxing. Maybe there's better place to do it than in Update()? I can add an event later if you like. :)
Update is ok for now I guess, but events would be the most performant solution I guess (and less error-prone)

haloterm
Posts: 344
Joined: Sat Feb 16, 2019 5:21 am

Re: Enhanced Sky

Post by haloterm »

When pressing F10 to show the classic UI, the sky gets black :)

User avatar
Nystul
Posts: 1497
Joined: Mon Mar 23, 2015 8:31 am

Re: Enhanced Sky

Post by Nystul »

haloterm wrote: Mon Nov 22, 2021 9:04 pm When pressing F10 to show the classic UI, the sky gets black :)
better not press F10 then... :D

will take a look at the weekend

User avatar
Interkarma
Posts: 6592
Joined: Sun Mar 22, 2015 1:51 am

Re: Enhanced Sky

Post by Interkarma »

Nystul, apologies for not covering this one in my PR to Enhanced Sky. I didn't catch it.

F10 toggles between fullscreen and large HUD. Just like changing resolutions, mod will need to update render target anytime this changes. Should only require a few lines of code, and I'm happy to help with another PR if needed. :)

To workaround in short term, restarting game after toggling fullscreen/large HUD will also resolve. Mod picks up correct render target at start, just not when switched at runtime. I imagine older versions of DFU+sky also had this issue as how this works hasn't changed in 0.13.

User avatar
pango
Posts: 3059
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Enhanced Sky

Post by pango »

At least for this change there's a delegate/event: DaggerfallHUD.OnLargeHUDToggle
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Nystul
Posts: 1497
Joined: Mon Mar 23, 2015 8:31 am

Re: Enhanced Sky

Post by Nystul »

pango wrote: Wed Nov 24, 2021 8:23 am At least for this change there's a delegate/event: DaggerfallHUD.OnLargeHUDToggle
this makes matters pretty easy then... great ;)

User avatar
Nystul
Posts: 1497
Joined: Mon Mar 23, 2015 8:31 am

Re: Enhanced Sky

Post by Nystul »

ok, even without Enhanced Sky mod active retro mode in combination with LargeHUD is broken, see this bug report: http://forums.dfworkshop.net/viewtopic. ... d26#p58421

Post Reply