Assuming it's anything like later Java GCs, a parallel collector still needs to block other threads during 2 phases of the overall process. Unfortunately while I'm a moderate expert on Java GCs (prior to java 8) I know nothing about C# GCs.
[MOD] Distant Terrain
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: [MOD] Distant Terrain
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: [MOD] Distant Terrain
Right, hence my careful choice of words... walking stacks is not something you want to do on live processes, for example.
Anyway, that means that the timings logged by UnloadUnusedAssets() may be a poor indicator of how much your program is impacted by assets gc.
Also, what happens if one calls gc in rapid fire like I did for this benchmark? That could very well be meaningless, even if the timings above look similar to what I've seen in normal game logs...
So, sorry for the noise
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Nystul
- Posts: 1501
- Joined: Mon Mar 23, 2015 8:31 am
Re: [MOD] Distant Terrain
these are interesting and valuable findings.
Regarding DT mod I am not sure if it is a good idea to remove the UnloadUnusedAssets() call. People were reporting in the past that they get crashes if it isn't called after walking around for some time
Regarding DT mod I am not sure if it is a good idea to remove the UnloadUnusedAssets() call. People were reporting in the past that they get crashes if it isn't called after walking around for some time
-
- Posts: 833
- Joined: Mon Nov 30, 2015 6:32 pm
Re: [MOD] Distant Terrain
It sounds like you're calling it once per terrain gen? Maybe call it once every four? Or let people use a setting?
Previous experience tells me it's very easy to misunderstand the tone, intent, or meaning of what I've posted. If you have questions, ask.
- Nystul
- Posts: 1501
- Joined: Mon Mar 23, 2015 8:31 am
Re: [MOD] Distant Terrain
not sure how often core calls it but dt mod only calls it when player moves to new map pixel
does anyone know if this call must happen in the unity main thread? I fear so but if not we could try to do it in a separate thread
does anyone know if this call must happen in the unity main thread? I fear so but if not we could try to do it in a separate thread
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: [MOD] Distant Terrain
I'll take a look with the profiler and report back what it shows. (or my interpretation of what it shows at least)
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: [MOD] Distant Terrain
Hi guys,
I was just testing the southern border of the map, and strange things happen with Distant Terrain... Both unmodded DFU and Mountains and Hills behave correctly (or at least, as before: you arrive at a clean-cut end of the world)
I haven't checked the other borders.
I was just testing the southern border of the map, and strange things happen with Distant Terrain... Both unmodded DFU and Mountains and Hills behave correctly (or at least, as before: you arrive at a clean-cut end of the world)
I haven't checked the other borders.
- Attachments
-
- SAVE239_end_of_the_world.zip
- (401.7 KiB) Downloaded 155 times
-
- SAVE238_pyramids.zip
- (418.34 KiB) Downloaded 146 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Midknightprince
- Posts: 1324
- Joined: Fri Aug 11, 2017 6:51 am
- Location: San Antonio TX
- Contact:
Re: [MOD] Distant Terrain
This is still working for me in the current live build Windows 10
Check out my YouTube Channel!
- King of Worms
- Posts: 4753
- Joined: Mon Oct 17, 2016 11:18 pm
- Location: Scourg Barrow (CZ)
- Contact:
Re: [MOD] Distant Terrain
Its working but with this mod, I cant exit the game. It freezes and I need to exit it using the CTRL+ALT+DEL
Windows 7 x64
Anyone has the same issue?
Windows 7 x64
Anyone has the same issue?
DREAM Nexus https://www.nexusmods.com/users/73250038?tab=user+files
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
- jayhova
- Posts: 924
- Joined: Wed Jul 19, 2017 7:54 pm
- Contact: