Item stacking [RESOLVED]

User avatar
Prester Lewin
Posts: 96
Joined: Thu Sep 13, 2018 2:16 pm

Re: Item stacking [RESOLVED]

Post by Prester Lewin »

Sorry, I understand that this isn't a major concern, but I'd like to keep it on record that while this bug is probably resolved for quest items (I haven't encountered it again), it still happens to random enchanted loot items that they get stacked with other items of the same type. Today, I found an enchanted sapphire of far silence and it got stacked with 3 other unenchanted sapphires in my inventory.

This is in 64 bit #137.

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Item stacking [RESOLVED]

Post by pango »

Oh, enchanted ingredients, totally forgot about those!
The good thing is, with previous refactorization it''s an easy fix.
I submitted a PR
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Prester Lewin
Posts: 96
Joined: Thu Sep 13, 2018 2:16 pm

Re: Item stacking [RESOLVED]

Post by Prester Lewin »

pango wrote: Sat Oct 20, 2018 4:26 pm Oh, enchanted ingredients, totally forgot about those!
The good thing is, with previous refactorization it''s an easy fix.
I submitted a PR
Great, thanks!

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Item stacking [RESOLVED]

Post by pango »

There's another corner case that will need fixing; Gems can not only be enchanted (*), but they can also be equipped!
So not only should equipped items not be stacked, but when equipping a stack I think only one item should be equipped, which requires stack splitting...

*; beware of item maker vs stacks later
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Item stacking [RESOLVED]

Post by pango »

I submitted a third PR for those cases
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Locked