Dev build/Linux: can't live edit character's name [RESOLVED]

Post Reply
User avatar
pango
Posts: 275
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Dev build/Linux: can't live edit character's name [RESOLVED]

Post by pango » Sun Oct 14, 2018 9:45 am

In Daggerfall classic you can change your name at any time by clicking on it in character's sheet.
(However it could conflict with loading/saving screens that regroup gamesaves by character)
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Hazelnut
Posts: 849
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: can't live edit character's name

Post by Hazelnut » Wed Oct 17, 2018 8:08 pm

I wonder how many people even know that's possible? Shouldn't be too hard to do, and the grouping of characters should still work I think. Although renaming would split the character saves over multiple name 'slots'.

EDIT: Done and PR submitted.

User avatar
Interkarma
Posts: 3488
Joined: Sun Mar 22, 2015 1:51 am

Re: Dev build/Linux: can't live edit character's name

Post by Interkarma » Wed Oct 17, 2018 8:27 pm

What Hazelnut said. :)

Easy to do - temporarily hide name label and show textbox to enter new name (prepolulated with current name).

I think the save/load handling is robust enough to do this without any problems, but might briefly confuse users when they next open save UI and all their saves are "missing" as new character is technically first save under new name. I don't see any roadbloacks doing this.

User avatar
Hazelnut
Posts: 849
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: can't live edit character's name [RESOLVED]

Post by Hazelnut » Wed Oct 17, 2018 8:55 pm

Why is there any need to hide the label? I think it's fine to leave it visible, and that's what classic does. (and my PR just submitted ;-))

User avatar
Interkarma
Posts: 3488
Joined: Sun Mar 22, 2015 1:51 am

Re: Dev build/Linux: can't live edit character's name [RESOLVED]

Post by Interkarma » Wed Oct 17, 2018 9:02 pm

Nevermind, I was thinking of a solution where user edits directly over the top of existing name in-situ. I see classic uses a messagebox popup, which is better.

Post Reply