Page 1 of 1

Dev build/Linux: can't live edit character's name [RESOLVED]

Posted: Sun Oct 14, 2018 9:45 am
by pango
In Daggerfall classic you can change your name at any time by clicking on it in character's sheet.
(However it could conflict with loading/saving screens that regroup gamesaves by character)

Re: Dev build/Linux: can't live edit character's name

Posted: Wed Oct 17, 2018 8:08 pm
by Hazelnut
I wonder how many people even know that's possible? Shouldn't be too hard to do, and the grouping of characters should still work I think. Although renaming would split the character saves over multiple name 'slots'.

EDIT: Done and PR submitted.

Re: Dev build/Linux: can't live edit character's name

Posted: Wed Oct 17, 2018 8:27 pm
by Interkarma
What Hazelnut said. :)

Easy to do - temporarily hide name label and show textbox to enter new name (prepolulated with current name).

I think the save/load handling is robust enough to do this without any problems, but might briefly confuse users when they next open save UI and all their saves are "missing" as new character is technically first save under new name. I don't see any roadbloacks doing this.

Re: Dev build/Linux: can't live edit character's name [RESOLVED]

Posted: Wed Oct 17, 2018 8:55 pm
by Hazelnut
Why is there any need to hide the label? I think it's fine to leave it visible, and that's what classic does. (and my PR just submitted ;-))

Re: Dev build/Linux: can't live edit character's name [RESOLVED]

Posted: Wed Oct 17, 2018 9:02 pm
by Interkarma
Nevermind, I was thinking of a solution where user edits directly over the top of existing name in-situ. I see classic uses a messagebox popup, which is better.