#140 Not seeing guild promotion message [RESOLVED]

Locked
User avatar
Hazelnut
Posts: 3016
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

#140 Not seeing guild promotion message [RESOLVED]

Post by Hazelnut »

Play testing #140 on linux and not seeing guild promotion message when I get promoted. Playing in editor works fine, so could be the click closing the message before it's even displayed issues again. I thought this had been fixed though so going to try it on windows and see what is going on.
SAVE67.zip
(192.8 KiB) Downloaded 72 times
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Hazelnut
Posts: 3016
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: #140 Not seeing guild promotion message

Post by Hazelnut »

Same thing on windows, works in editor but not with the standalone build. Turns out there are a few uses of message box that just push to UI instead of calling Show() to do it which means the fix for click opening and immediately closing again was not active. Have submitted a PR with fixes. There are still a few other instances where this is being done for click to close message boxes, mainly in DaggerfallCourtWindow.cs, but I've left them alone since there might be a good reason I am unaware of.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Interkarma
Posts: 7247
Joined: Sun Mar 22, 2015 1:51 am

Re: #140 Not seeing guild promotion message [RESOLVED]

Post by Interkarma »

I've backported this to 0.5 stable. New 0.5 builds will be made available soon with this fix.

Locked