Page 1 of 1
0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Thu Feb 07, 2019 2:10 am
by Jay_H
I'm testing this on #147 but I don't think that's a deciding factor. I can increase legal repute without an issue, but the command won't decrease it.
Code: Select all
_repfail_ task:
remove foe _nme_
legal repute -20
end quest
leads to
Code: Select all
Action not found. Ignoring ' legal repute -20'
This is relevant for classic quest
The Mixup, k0c00y06, which uses the same quest action.
Re: 0.7.32: Action not found. Ignoring ' legal repute -20'
Posted: Thu Feb 07, 2019 2:53 am
by Interkarma
Thanks for letting me know, probably just a regex issue. Will fix up soon.
Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Wed Mar 13, 2019 12:14 pm
by Interkarma
I've updated "legal repute" regex to allow negative or positive integers.
Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Wed Mar 13, 2019 1:34 pm
by Jay_H
Cool, thanks Interkarma
Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Sat Mar 16, 2019 10:12 pm
by TheLacus
Can you confirm if the plus sign is to be considered optional for positive values? Tipton's docs and all classic quests use +/- when an integer is expected (see change repute with) so i followed this behaviour for the quest editor that i worked on. Now i opened it after a long time and saw a lot of errors in Jay_H quests due to this, so i will need to fix it for next update but i wanted to check with you if this is intentional.
Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Sat Mar 16, 2019 10:41 pm
by Jay_H
"legal repute" as a positive is only ever used once in Daggerfall. The other three uses are negative. All cases use signing.
http://github.com/Interkarma/daggerfall ... 000015.txt
http://github.com/Interkarma/daggerfall ... C00Y08.txt
http://github.com/Interkarma/daggerfall ... C00Y06.txt
Unless Interkarma knows something more, there's no evidence the command was meant to be used unsigned.
Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Sun Mar 17, 2019 1:29 am
by Interkarma
Thank you Jay. I'll rework expression to support explicit positive and negative signing.
Edit: I've now tweaked this so all of the following are valid:
Code: Select all
legal repute 10
legal repute +10
legal repute -10
Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Sun Mar 17, 2019 2:10 am
by Jay_H
Ah, you didn't have to do that. I changed all my signage to be explicit anyway
Thanks for the update.
Re: 0.7.32: Action not found. Ignoring ' legal repute -20' [RESOLVED]
Posted: Sun Mar 17, 2019 10:27 pm
by TheLacus
Interkarma wrote: ↑Sun Mar 17, 2019 1:29 am
I've now tweaked this so all of the following are valid
Thanks
